Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp

Issue 2726723002: Remove default arguments from V8ScriptRunner::compileScript()s (Closed)
Patch Set: Fix unit tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp
index cbc2fd173500dfe723e94d0dbf829468cc211867..c0bde6fc0521a4d553138d63fe090c101218b7e3 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp
@@ -134,7 +134,9 @@ TEST_F(ScriptStreamingTest, CompilingStreamedScript) {
EXPECT_TRUE(sourceCode.streamer());
v8::TryCatch tryCatch(scope.isolate());
v8::Local<v8::Script> script;
- EXPECT_TRUE(V8ScriptRunner::compileScript(sourceCode, scope.isolate())
+ EXPECT_TRUE(V8ScriptRunner::compileScript(sourceCode, scope.isolate(),
+ SharableCrossOrigin,
+ V8CacheOptionsDefault)
.ToLocal(&script));
EXPECT_FALSE(tryCatch.HasCaught());
}
@@ -171,7 +173,9 @@ TEST_F(ScriptStreamingTest, CompilingStreamedScriptWithParseError) {
EXPECT_TRUE(sourceCode.streamer());
v8::TryCatch tryCatch(scope.isolate());
v8::Local<v8::Script> script;
- EXPECT_FALSE(V8ScriptRunner::compileScript(sourceCode, scope.isolate())
+ EXPECT_FALSE(V8ScriptRunner::compileScript(sourceCode, scope.isolate(),
+ SharableCrossOrigin,
+ V8CacheOptionsDefault)
.ToLocal(&script));
EXPECT_TRUE(tryCatch.HasCaught());
}
@@ -317,7 +321,9 @@ TEST_F(ScriptStreamingTest, ScriptsWithSmallFirstChunk) {
EXPECT_TRUE(sourceCode.streamer());
v8::TryCatch tryCatch(scope.isolate());
v8::Local<v8::Script> script;
- EXPECT_TRUE(V8ScriptRunner::compileScript(sourceCode, scope.isolate())
+ EXPECT_TRUE(V8ScriptRunner::compileScript(sourceCode, scope.isolate(),
+ SharableCrossOrigin,
+ V8CacheOptionsDefault)
.ToLocal(&script));
EXPECT_FALSE(tryCatch.HasCaught());
}
@@ -351,7 +357,9 @@ TEST_F(ScriptStreamingTest, EncodingChanges) {
EXPECT_TRUE(sourceCode.streamer());
v8::TryCatch tryCatch(scope.isolate());
v8::Local<v8::Script> script;
- EXPECT_TRUE(V8ScriptRunner::compileScript(sourceCode, scope.isolate())
+ EXPECT_TRUE(V8ScriptRunner::compileScript(sourceCode, scope.isolate(),
+ SharableCrossOrigin,
+ V8CacheOptionsDefault)
.ToLocal(&script));
EXPECT_FALSE(tryCatch.HasCaught());
}
@@ -385,7 +393,9 @@ TEST_F(ScriptStreamingTest, EncodingFromBOM) {
EXPECT_TRUE(sourceCode.streamer());
v8::TryCatch tryCatch(scope.isolate());
v8::Local<v8::Script> script;
- EXPECT_TRUE(V8ScriptRunner::compileScript(sourceCode, scope.isolate())
+ EXPECT_TRUE(V8ScriptRunner::compileScript(sourceCode, scope.isolate(),
+ SharableCrossOrigin,
+ V8CacheOptionsDefault)
.ToLocal(&script));
EXPECT_FALSE(tryCatch.HasCaught());
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698