Add test-only constructor for PageLoadExtraInfo.

Add test-only constructor for PageLoadExtraInfo.

prerender_browsertest.cc wants to create fake PageLoadExtraInfos.
We have to make a change there every time we update the constructor.
This helper allows for construction of PLEIs using a minimal set of
parameters, in order to avoid the need to update
prerender_browsertest.cc in the future.

BUG=697189
Review-Url: https://codereview.chromium.org/2726673002
Cr-Commit-Position: refs/heads/master@{#453742}
Committed: https://chromium.googlesource.com/chromium/src/+/eb24ee6ddf845f326802315fec6748f49e7e253d

[Bryan McQuade, 2017-02-28 20:54:33]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 20:55:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2017-02-28 20:56:35]

Description was changed from

==========
Add test-only constructor for PageLoadExtraInfo.

BUG=
==========

to

==========
Add test-only constructor for PageLoadExtraInfo.

prerender_browsertest.cc wants to create fake PageLoadExtraInfos.
We have to make a change there every time we update the constructor.
This helper allows for construction of PLEIs using a minimal set of
parameters, in order to avoid the need to update
prerender_browsertest.cc in the future.

BUG=697189
==========

[Bryan McQuade, 2017-02-28 20:56:52]

bmcquade@chromium.org changed reviewers:
+ csharrison@chromium.org, mattcary@chromium.org

[Bryan McQuade, 2017-02-28 20:56:58]

PTAL, thanks!

[Charlie Harrison, 2017-02-28 21:01:12]

lgtm

https://codereview.chromium.org/2726673002/diff/1/chrome/browser/page_load_me...
File chrome/browser/page_load_metrics/page_load_metrics_observer.h (right):

https://codereview.chromium.org/2726673002/diff/1/chrome/browser/page_load_me...
chrome/browser/page_load_metrics/page_load_metrics_observer.h:123: static
PageLoadExtraInfo CreateForTest(const GURL& url,
ForTesting is the more common naming scheme.

[Bryan McQuade, 2017-02-28 21:05:29]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[Bryan McQuade, 2017-02-28 21:05:45]

https://codereview.chromium.org/2726673002/diff/1/chrome/browser/page_load_me...
File chrome/browser/page_load_metrics/page_load_metrics_observer.h (right):

https://codereview.chromium.org/2726673002/diff/1/chrome/browser/page_load_me...
chrome/browser/page_load_metrics/page_load_metrics_observer.h:123: static
PageLoadExtraInfo CreateForTest(const GURL& url,
On 2017/02/28 at 21:01:12, Charlie Harrison wrote:
> ForTesting is the more common naming scheme.

done

[commit-bot: I haz the power, 2017-02-28 21:05:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattcary, 2017-02-28 21:28:55]

lgtm

:)

Thanks!

[commit-bot: I haz the power, 2017-02-28 22:06:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 22:06:39]

Dry run: This issue passed the CQ dry run.

[Bryan McQuade, 2017-02-28 22:06:48]

The CQ bit was checked by bmcquade@chromium.org

[Bryan McQuade, 2017-02-28 22:06:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
csharrison@chromium.org
Link to the patchset: https://codereview.chromium.org/2726673002/#ps20001
(title: "address comment")

[commit-bot: I haz the power, 2017-02-28 22:07:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 23:30:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488319608873150,
"parent_rev": "b42ea2f57ed5544e110b6d9aff2c2568e3c499c2", "commit_rev":
"eb24ee6ddf845f326802315fec6748f49e7e253d"}

[commit-bot: I haz the power, 2017-02-28 23:31:27]

Description was changed from

==========
Add test-only constructor for PageLoadExtraInfo.

prerender_browsertest.cc wants to create fake PageLoadExtraInfos.
We have to make a change there every time we update the constructor.
This helper allows for construction of PLEIs using a minimal set of
parameters, in order to avoid the need to update
prerender_browsertest.cc in the future.

BUG=697189
==========

to

==========
Add test-only constructor for PageLoadExtraInfo.

prerender_browsertest.cc wants to create fake PageLoadExtraInfos.
We have to make a change there every time we update the constructor.
This helper allows for construction of PLEIs using a minimal set of
parameters, in order to avoid the need to update
prerender_browsertest.cc in the future.

BUG=697189

Review-Url: https://codereview.chromium.org/2726673002
Cr-Commit-Position: refs/heads/master@{#453742}
Committed:
https://chromium.googlesource.com/chromium/src/+/eb24ee6ddf845f326802315fec67...
==========

[commit-bot: I haz the power, 2017-02-28 23:31:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/eb24ee6ddf845f326802315fec67...