Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3884)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_observer.cc

Issue 2726673002: Add test-only constructor for PageLoadExtraInfo. (Closed)
Patch Set: address comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
index 8d1bb0286fbbd9cb633bbd796ef596df89b46f07..25f192724dc04769a872876ea8bc3bbca42f8cc3 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
@@ -34,6 +34,20 @@ PageLoadExtraInfo::PageLoadExtraInfo(const PageLoadExtraInfo& other) = default;
PageLoadExtraInfo::~PageLoadExtraInfo() {}
+// static
+PageLoadExtraInfo PageLoadExtraInfo::CreateForTesting(
+ const GURL& url,
+ bool started_in_foreground) {
+ return PageLoadExtraInfo(
+ base::Optional<base::TimeDelta>() /* first_background_time */,
+ base::Optional<base::TimeDelta>() /* first_foreground_time */,
+ started_in_foreground /* started_in_foreground */,
+ UserInitiatedInfo::BrowserInitiated(), url, url, true /* did_commit */,
+ page_load_metrics::END_NONE,
+ page_load_metrics::UserInitiatedInfo::NotUserInitiated(),
+ base::TimeDelta(), page_load_metrics::PageLoadMetadata());
+}
+
ExtraRequestInfo::ExtraRequestInfo(bool was_cached,
int64_t raw_body_bytes,
bool data_reduction_proxy_used,
« no previous file with comments | « chrome/browser/page_load_metrics/page_load_metrics_observer.h ('k') | chrome/browser/prerender/prerender_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698