Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_observer.h

Issue 2726673002: Add test-only constructor for PageLoadExtraInfo. (Closed)
Patch Set: address comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/page_load_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_observer.h b/chrome/browser/page_load_metrics/page_load_metrics_observer.h
index 0f9cc76a98b28861db918463c35afafe9c0ba5f0..aec560c20262e97e071ce88906c22908c515a550 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/page_load_metrics_observer.h
@@ -119,6 +119,10 @@ struct PageLoadExtraInfo {
const base::Optional<base::TimeDelta>& page_end_time,
const PageLoadMetadata& metadata);
+ // Simplified version of the constructor, intended for use in tests.
+ static PageLoadExtraInfo CreateForTesting(const GURL& url,
+ bool started_in_foreground);
+
PageLoadExtraInfo(const PageLoadExtraInfo& other);
~PageLoadExtraInfo();
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/page_load_metrics_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698