Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2726233003: [LayoutNG] Remove style_ and layout_result_ members on NGBlockNode. (Closed)

Created:
3 years, 9 months ago by ikilpatrick
Modified:
3 years, 9 months ago
Reviewers:
cbiesinger
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Remove style_ and layout_result_ members on NGBlockNode. They aren't really needed now. Eventually we'll want NGBlockNode to just be a POD around the layout object to remove overhead. After this we can transition NGBlockNode to just be a POD (NGInlineNode needs a bit more work). BUG=635619 Review-Url: https://codereview.chromium.org/2726233003 Cr-Commit-Position: refs/heads/master@{#454689} Committed: https://chromium.googlesource.com/chromium/src/+/50019db39aa7c456d30552d8bc3c1e2747c5101f

Patch Set 1 #

Patch Set 2 : first! #

Patch Set 3 : fix test which had un-owned fragment tree. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -19 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.h View 1 chunk +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.cc View 3 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
ikilpatrick
I don't know if this mucks up your cache work; but my thought is that ...
3 years, 9 months ago (2017-03-02 21:49:43 UTC) #4
cbiesinger
lgtm, I don't think I'll need these
3 years, 9 months ago (2017-03-02 22:26:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2726233003/20001
3 years, 9 months ago (2017-03-02 22:38:30 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/401661)
3 years, 9 months ago (2017-03-02 22:58:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2726233003/40001
3 years, 9 months ago (2017-03-03 20:26:38 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 22:20:42 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/50019db39aa7c456d30552d8bc3c...

Powered by Google App Engine
This is Rietveld 408576698