Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_node.h

Issue 2726233003: [LayoutNG] Remove style_ and layout_result_ members on NGBlockNode. (Closed)
Patch Set: fix test which had un-owned fragment tree. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_block_node.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_node.h b/third_party/WebKit/Source/core/layout/ng/ng_block_node.h
index 7b7a145564dc5c3b8eb8fa6c2a2b96bc2a64c47e..fe6c05370728e4dd692c261168e2443856f4dfcb 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_block_node.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_node.h
@@ -67,18 +67,13 @@ class CORE_EXPORT NGBlockNode final : public NGLayoutInputNode {
// After we run the layout algorithm, this function copies back the geometry
// data to the layout box.
- void CopyFragmentDataToLayoutBox(const NGConstraintSpace&);
+ void CopyFragmentDataToLayoutBox(const NGConstraintSpace&, NGLayoutResult*);
- // We can either wrap a layout_box_ or a style_/next_sibling_/first_child_
+ // We can either wrap a layout_box_ or a next_sibling_/first_child_
// combination.
LayoutBox* layout_box_;
- RefPtr<ComputedStyle> style_;
Member<NGLayoutInputNode> next_sibling_;
Member<NGLayoutInputNode> first_child_;
- // TODO(mstensho): An input node may produce multiple fragments, so this
- // should probably be renamed to last_result_ or something like that, since
- // the last fragment is all we care about when resuming layout.
- RefPtr<NGLayoutResult> layout_result_;
};
DEFINE_TYPE_CASTS(NGBlockNode,

Powered by Google App Engine
This is Rietveld 408576698