third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc - Issue 2726233003: [LayoutNG] Remove style_ and layout_result_ members on NGBlockNode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

Issue 2726233003: [LayoutNG] Remove style_ and layout_result_ members on NGBlockNode. (Closed)

Patch Set: fix test which had un-owned fragment tree. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

index 85f9ad3d37b44e66e297791405e6f20a0ebad2ed..38c457208c4f506cf5d7d4062d869bbd8d423fd4 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

@@ -1174,8 +1174,8 @@ TEST_F(NGBlockLayoutAlgorithmTest, PositionFragmentsWithClear) {

const NGPhysicalBoxFragment* container_fragment;

const NGPhysicalBoxFragment* block_fragment;

const NGPhysicalBoxFragment* adjoining_clearance_fragment;

+ RefPtr<const NGPhysicalBoxFragment> fragment;

auto run_with_clearance = [&](EClear clear_value) {

- RefPtr<NGPhysicalBoxFragment> fragment;

Element* el_with_clear = document().getElementById("clearance");

el_with_clear->mutableComputedStyle()->setClear(clear_value);

std::tie(fragment, std::ignore) = RunBlockLayoutAlgorithmForElement(

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ng/ng_block_node.h » ('j') | no next file with comments »