MD Settings: re-fix relative paper-input-label font-size.

MD Settings: re-fix relative paper-input-label font-size.

In a previous attempt to make paper-input-label font-size relative (https://codereview.chromium.org/2715863002), I actually shrunk the size by a couple pixels comparing to the original design. This new CL aims to fix the unintended change, and also bring one other hard-coded label in line.

BUG=697726, 697341, 697778, 697340
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2726113003
Cr-Commit-Position: refs/heads/master@{#454940}
Committed: https://chromium.googlesource.com/chromium/src/+/3ed5d998cc82797b116a949f75da144ec3465a6d

[scottchen, 2017-03-02 21:37:11]

Description was changed from

==========
MD Settings: re-fix relative paper-input-label font-size.

In a previous attempt to make paper-input-label font-size relative
(https://codereview.chromium.org/2715863002), I actually shrunk the size by a
couple pixels comparing to the original design. This new CL aims to fix the
unintended change, and also bring one other hard-coded label in line.

BUG=697726
==========

to

==========
MD Settings: re-fix relative paper-input-label font-size.

In a previous attempt to make paper-input-label font-size relative
(https://codereview.chromium.org/2715863002), I actually shrunk the size by a
couple pixels comparing to the original design. This new CL aims to fix the
unintended change, and also bring one other hard-coded label in line.

BUG=697726
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[scottchen, 2017-03-02 21:41:35]

scottchen@chromium.org changed reviewers:
+ dpapad@chromium.org

[scottchen, 2017-03-02 21:41:36]

see screenshots for different font-sizes after the fix: http://imgur.com/a/DQyuj
(the "before" screen capture is in the bug)

[scottchen, 2017-03-02 23:05:08]

Description was changed from

==========
MD Settings: re-fix relative paper-input-label font-size.

In a previous attempt to make paper-input-label font-size relative
(https://codereview.chromium.org/2715863002), I actually shrunk the size by a
couple pixels comparing to the original design. This new CL aims to fix the
unintended change, and also bring one other hard-coded label in line.

BUG=697726
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: re-fix relative paper-input-label font-size.

In a previous attempt to make paper-input-label font-size relative
(https://codereview.chromium.org/2715863002), I actually shrunk the size by a
couple pixels comparing to the original design. This new CL aims to fix the
unintended change, and also bring one other hard-coded label in line.

BUG=697726,697341
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[scottchen, 2017-03-03 00:37:55]

Description was changed from

==========
MD Settings: re-fix relative paper-input-label font-size.

In a previous attempt to make paper-input-label font-size relative
(https://codereview.chromium.org/2715863002), I actually shrunk the size by a
couple pixels comparing to the original design. This new CL aims to fix the
unintended change, and also bring one other hard-coded label in line.

BUG=697726,697341
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: re-fix relative paper-input-label font-size.

In a previous attempt to make paper-input-label font-size relative
(https://codereview.chromium.org/2715863002), I actually shrunk the size by a
couple pixels comparing to the original design. This new CL aims to fix the
unintended change, and also bring one other hard-coded label in line.

BUG=697726,697341,697778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[scottchen, 2017-03-03 01:03:58]

Description was changed from

==========
MD Settings: re-fix relative paper-input-label font-size.

In a previous attempt to make paper-input-label font-size relative
(https://codereview.chromium.org/2715863002), I actually shrunk the size by a
couple pixels comparing to the original design. This new CL aims to fix the
unintended change, and also bring one other hard-coded label in line.

BUG=697726,697341,697778
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: re-fix relative paper-input-label font-size.

In a previous attempt to make paper-input-label font-size relative
(https://codereview.chromium.org/2715863002), I actually shrunk the size by a
couple pixels comparing to the original design. This new CL aims to fix the
unintended change, and also bring one other hard-coded label in line.

BUG=697726,697341,697778,697340
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[scottchen, 2017-03-03 19:03:07]

On 2017/03/02 21:41:36, scottchen wrote:
> see screenshots for different font-sizes after the fix:
http://imgur.com/a/DQyuj
> (the "before" screen capture is in the bug)

See also - 
placeholder text doesn't touch the bottom line anymore: http://imgur.com/a/MCjwn
Typing in the manage password searchbox doesn't push content down anymore:
https://drive.google.com/a/google.com/file/d/0ByIc0PEad7DmYklTZTU3TVBBMEU/vie...

[dpapad, 2017-03-03 22:23:28]

LGTM

https://codereview.chromium.org/2726113003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_vars_css.html (right):

https://codereview.chromium.org/2726113003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/settings_vars_css.html:116: line-height:
1.25rem;
I am not familiar enough with rem units. It sounds like they make it easier to
adjust all fonts based on a single "top-level" value than making complex
calculations depending on all parents between the current element and the root
of the DOM. Is my understanding accurate? If so, should we be using them more
extensively?

[Dan Beam, 2017-03-03 22:33:38]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2017-03-03 22:33:39]

https://codereview.chromium.org/2726113003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_vars_css.html (right):

https://codereview.chromium.org/2726113003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/settings_vars_css.html:116: line-height:
1.25rem;
On 2017/03/03 22:23:27, dpapad wrote:
> I am not familiar enough with rem units. It sounds like they make it easier to
> adjust all fonts based on a single "top-level" value than making complex
> calculations depending on all parents between the current element and the root
> of the DOM. Is my understanding accurate? If so, should we be using them more
> extensively?

yes, rem are good

[scottchen, 2017-03-06 18:29:55]

https://codereview.chromium.org/2726113003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_vars_css.html (right):

https://codereview.chromium.org/2726113003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/settings_vars_css.html:116: line-height:
1.25rem;
On 2017/03/03 22:33:39, Dan Beam wrote:
> On 2017/03/03 22:23:27, dpapad wrote:
> > I am not familiar enough with rem units. It sounds like they make it easier
to
> > adjust all fonts based on a single "top-level" value than making complex
> > calculations depending on all parents between the current element and the
root
> > of the DOM. Is my understanding accurate? If so, should we be using them
more
> > extensively?
> 
> yes, rem are good

Yeah, I think we should try to use rem where we can, since they ignore
parent-element's font sizes like you said. This makes it easier to have
consistent yet scalable font-sizes.

[scottchen, 2017-03-06 18:30:03]

The CQ bit was checked by scottchen@chromium.org

[commit-bot: I haz the power, 2017-03-06 18:30:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 20:28:06]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488825003335910,
"parent_rev": "fcf82d6e5b20e104b5eaba8d802ee451092126d5", "commit_rev":
"3ed5d998cc82797b116a949f75da144ec3465a6d"}

[commit-bot: I haz the power, 2017-03-06 20:28:45]

Description was changed from

==========
MD Settings: re-fix relative paper-input-label font-size.

In a previous attempt to make paper-input-label font-size relative
(https://codereview.chromium.org/2715863002), I actually shrunk the size by a
couple pixels comparing to the original design. This new CL aims to fix the
unintended change, and also bring one other hard-coded label in line.

BUG=697726,697341,697778,697340
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: re-fix relative paper-input-label font-size.

In a previous attempt to make paper-input-label font-size relative
(https://codereview.chromium.org/2715863002), I actually shrunk the size by a
couple pixels comparing to the original design. This new CL aims to fix the
unintended change, and also bring one other hard-coded label in line.

BUG=697726,697341,697778,697340
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2726113003
Cr-Commit-Position: refs/heads/master@{#454940}
Committed:
https://chromium.googlesource.com/chromium/src/+/3ed5d998cc82797b116a949f75da...
==========

[commit-bot: I haz the power, 2017-03-06 20:28:46]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3ed5d998cc82797b116a949f75da...