Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2715863002: MD Settings: make input label and error font size relative. (Closed)

Created:
3 years, 10 months ago by scottchen
Modified:
3 years, 9 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: make input label and error font size relative. Prior to this CL, paper-input's label and error messages have a fixed font-size of 12px, so when the user changes their browser's font-size setting, the input label and error message font size will look very odd. BUG=672416 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2715863002 Cr-Commit-Position: refs/heads/master@{#453684} Committed: https://chromium.googlesource.com/chromium/src/+/aa40908dd04900048559b86f7eeae484e6623e11

Patch Set 1 #

Patch Set 2 : prevent error-message from overlapping #

Patch Set 3 : overflowing error message so large fonts dont ellipsis #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/browser/resources/settings/people_page/sync_page.html View 1 2 chunks +3 lines, -1 line 2 comments Download
M chrome/browser/resources/settings/settings_vars_css.html View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
scottchen
Screenshots for before/after (for both error message and input label): http://imgur.com/a/OPiG4
3 years, 10 months ago (2017-02-24 19:29:33 UTC) #3
dpapad
LGTM https://codereview.chromium.org/2715863002/diff/40001/chrome/browser/resources/settings/people_page/sync_page.html File chrome/browser/resources/settings/people_page/sync_page.html (right): https://codereview.chromium.org/2715863002/diff/40001/chrome/browser/resources/settings/people_page/sync_page.html#newcode46 chrome/browser/resources/settings/people_page/sync_page.html:46: /* TODO(scottchen): remove margin once large font properly ...
3 years, 10 months ago (2017-02-25 00:42:18 UTC) #5
scottchen
https://codereview.chromium.org/2715863002/diff/40001/chrome/browser/resources/settings/people_page/sync_page.html File chrome/browser/resources/settings/people_page/sync_page.html (right): https://codereview.chromium.org/2715863002/diff/40001/chrome/browser/resources/settings/people_page/sync_page.html#newcode46 chrome/browser/resources/settings/people_page/sync_page.html:46: /* TODO(scottchen): remove margin once large font properly padded. ...
3 years, 9 months ago (2017-02-28 18:47:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715863002/40001
3 years, 9 months ago (2017-02-28 18:47:36 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 20:15:46 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/aa40908dd04900048559b86f7eea...

Powered by Google App Engine
This is Rietveld 408576698