MD Settings: re-fix relative paper-input-label font-size.

chrome/browser/resources/settings/settings_vars_css.html

Index: chrome/browser/resources/settings/settings_vars_css.html
diff --git a/chrome/browser/resources/settings/settings_vars_css.html b/chrome/browser/resources/settings/settings_vars_css.html
index 1fa88f765cc21564c6c15657f9ea0aa01428392b..b234dfe52ef0bf1b83a17a18969d7e80f327058f 100644
--- a/chrome/browser/resources/settings/settings_vars_css.html
+++ b/chrome/browser/resources/settings/settings_vars_css.html
@@ -103,18 +103,23 @@
       color: inherit;
       font-size: inherit;
       font-weight: inherit;
-      line-height: inherit;
+      line-height: 154%;
       vertical-align: baseline;
     };
     --paper-input-container-label: {
       font-size: inherit;
-      line-height: inherit;
-    }
+      line-height: 154%;
+    };
+    --paper-input-container-label-floating: {
+      /* Using "rem" to make it easier to equalize with other labels. */
+      font-size: 1rem;
+      line-height: 1.25rem;

[dpapad, 2017/03/03 22:23:27]

I am not familiar enough with rem units. It sounds like they make it easier to
adjust all fonts based on a single "top-level" value than making complex
calculations depending on all parents between the current element and the root
of the DOM. Is my understanding accurate? If so, should we be using them more
extensively?

[Dan Beam, 2017/03/03 22:33:39]

yes, rem are good

[scottchen, 2017/03/06 18:29:54]

Yeah, I think we should try to use rem where we can, since they ignore
parent-element's font sizes like you said. This makes it easier to have
consistent yet scalable font-sizes.

+    };
     --paper-input-error: {
       font-size: 92.31%; /* Should be 12px when 100% is 13px. */
-      line-height: inherit;
+      line-height: 154%;
       overflow: visible; /* Half-visible error message is not useful at all. */
-    }
+    };
     --paper-input-max-width: 264px;
     --paper-radio-button-ink-size: 40px;
     --paper-radio-button-label-color: inherit;
@@ -135,7 +140,7 @@
 
     --settings-input-underline: {
       border-color: var(--paper-grey-300);
-    }
+    };
 
     --paper-input-container-underline: var(--settings-input-underline);
   }