Issue 2726083006: Do not load about:blank if iframe requested to load invalid URL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2726083006: Do not load about:blank if iframe requested to load invalid URL. (Closed)

Created:
3 years, 9 months ago by Eugene But (OOO till 7-30)

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

Do not load about:blank if iframe requested to load invalid URL. https://codereview.chromium.org/2397623002 prevents loading the page with invalid url and loads about blank:instead. This CL prevents loading about:blank if request is coming from iframe. BUG=694865 Review-Url: https://codereview.chromium.org/2709383002 Cr-Commit-Position: refs/heads/master@{#452371} (cherry picked from commit 74d58648b7106e3cf8dc31f667eb5e902e15caaa) Review-Url: https://codereview.chromium.org/2726083006 . Cr-Commit-Position: refs/branch-heads/2987@{#753} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/8a938a18f838db140a0ed9068ba6ac6320730599

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	ios/web/web_state/ui/crw_web_controller.mm	View		1 chunk	+8 lines, -5 lines	0 comments	Download

Total messages: 2 (1 generated)

Eugene But (OOO till 7-30)

3 years, 9 months ago (2017-03-03 18:30:23 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8a938a18f838db140a0ed9068ba6ac6320730599.