Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 2709383002: Do not load about:blank if iframe requested to load invalid URL. (Closed)

Created:
3 years, 10 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 10 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, Eugene But (OOO till 7-30)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not load about:blank if iframe requested to load invalid URL. https://codereview.chromium.org/2397623002 prevents loading the page with invalid url and loads about blank:instead. This CL prevents loading about:blank if request is coming from iframe. BUG=694865 Review-Url: https://codereview.chromium.org/2709383002 Cr-Commit-Position: refs/heads/master@{#452371} Committed: https://chromium.googlesource.com/chromium/src/+/74d58648b7106e3cf8dc31f667eb5e902e15caaa

Patch Set 1 #

Patch Set 2 : Handle gracefull nil target frame #

Patch Set 3 : Corrected frame check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 1 2 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Eugene But (OOO till 7-30)
3 years, 10 months ago (2017-02-22 23:53:06 UTC) #3
kkhorimoto
lgtm! sorry for breaking this!
3 years, 10 months ago (2017-02-23 01:09:10 UTC) #9
Eugene But (OOO till 7-30)
Thanks for quick review! No worries, I reviewed culprit CL :)
3 years, 10 months ago (2017-02-23 02:28:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709383002/40001
3 years, 10 months ago (2017-02-23 02:29:28 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 03:21:24 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/74d58648b7106e3cf8dc31f667eb...

Powered by Google App Engine
This is Rietveld 408576698