Don't allow link navigations for invalid URLs.

Don't allow link navigations for invalid URLs.

This CL cancels navigation actions for invalid URLs, loading about:blank
instead.  This matches the behavior in content/.

BUG=627581, 651854
Committed: https://crrev.com/8ad7f5ffc393f808323dd1d286cc00cc82161fc0
Cr-Commit-Position: refs/heads/master@{#423085}

[kkhorimoto, 2016-10-05 00:54:49]

kkhorimoto@chromium.org changed reviewers:
+ eugenebut@chromium.org, marq@chromium.org

[Eugene But (OOO till 7-30), 2016-10-05 00:58:40]

https://codereview.chromium.org/2397623002/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/2397623002/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.mm:4970: if (!requestURL.is_valid()) {
What |requestURL.is_valid()| would return for "about:blank" URLs? If the result
is false, then we can get into infinite loading loop.

[kkhorimoto, 2016-10-05 01:16:26]

https://codereview.chromium.org/2397623002/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/2397623002/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.mm:4970: if (!requestURL.is_valid()) {
On 2016/10/05 00:58:39, Eugene But wrote:
> What |requestURL.is_valid()| would return for "about:blank" URLs? If the
result
> is false, then we can get into infinite loading loop.

GURL("about:blank").is_valid() is true, so that's not an issue here.

[Eugene But (OOO till 7-30), 2016-10-05 01:41:45]

lgtm

https://codereview.chromium.org/2397623002/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/2397623002/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.mm:4972:
web::NavigationManager::WebLoadParams loadParams(GURL("about:blank"));
s/"about:blank"/kAboutBlankURL

[kkhorimoto, 2016-10-05 04:09:19]

https://codereview.chromium.org/2397623002/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/2397623002/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.mm:4972:
web::NavigationManager::WebLoadParams loadParams(GURL("about:blank"));
On 2016/10/05 01:41:44, Eugene But wrote:
> s/"about:blank"/kAboutBlankURL

Done.

[kkhorimoto, 2016-10-05 04:09:37]

Description was changed from

==========
Don't allow link navigations for invalid URLs.

This CL cancels navigation actions for invalid URLs, loading about:blank
instead.  This matches the behavior in content/.

BUG=627581
==========

to

==========
Don't allow link navigations for invalid URLs.

This CL cancels navigation actions for invalid URLs, loading about:blank
instead.  This matches the behavior in content/.

BUG=627581, 651854
==========

[kkhorimoto, 2016-10-05 04:09:41]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2016-10-05 04:09:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2397623002/#ps20001
(title: "kAboutBlankURL")

[commit-bot: I haz the power, 2016-10-05 04:09:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kkhorimoto, 2016-10-05 04:10:14]

The CQ bit was unchecked by kkhorimoto@chromium.org

[kkhorimoto, 2016-10-05 05:41:15]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2016-10-05 05:41:19]

The CQ bit was unchecked by kkhorimoto@chromium.org

[kkhorimoto, 2016-10-05 05:42:02]

Description was changed from

==========
Don't allow link navigations for invalid URLs.

This CL cancels navigation actions for invalid URLs, loading about:blank
instead.  This matches the behavior in content/.

BUG=627581, 651854
==========

to

==========
Don't allow link navigations for invalid URLs.

This CL cancels navigation actions for invalid URLs, loading about:blank
instead.  This matches the behavior in content/.

BUG=627581
==========

[kkhorimoto, 2016-10-05 05:42:06]

The CQ bit was checked by kkhorimoto@chromium.org

[commit-bot: I haz the power, 2016-10-05 05:42:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kkhorimoto, 2016-10-05 05:46:12]

The CQ bit was unchecked by kkhorimoto@chromium.org

[kkhorimoto, 2016-10-05 05:47:20]

Description was changed from

==========
Don't allow link navigations for invalid URLs.

This CL cancels navigation actions for invalid URLs, loading about:blank
instead.  This matches the behavior in content/.

BUG=627581
==========

to

==========
Don't allow link navigations for invalid URLs.

This CL cancels navigation actions for invalid URLs, loading about:blank
instead.  This matches the behavior in content/.

BUG=627581, 651854
==========

[kkhorimoto, 2016-10-05 05:47:26]

The CQ bit was checked by kkhorimoto@chromium.org

[commit-bot: I haz the power, 2016-10-05 05:47:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 05:55:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 05:55:16]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[kkhorimoto, 2016-10-05 06:02:01]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2016-10-05 06:02:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2397623002/#ps40001
(title: "compilation fix")

[commit-bot: I haz the power, 2016-10-05 06:02:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 06:11:19]

Description was changed from

==========
Don't allow link navigations for invalid URLs.

This CL cancels navigation actions for invalid URLs, loading about:blank
instead.  This matches the behavior in content/.

BUG=627581, 651854
==========

to

==========
Don't allow link navigations for invalid URLs.

This CL cancels navigation actions for invalid URLs, loading about:blank
instead.  This matches the behavior in content/.

BUG=627581, 651854
==========

[commit-bot: I haz the power, 2016-10-05 06:11:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-05 06:12:53]

Description was changed from

==========
Don't allow link navigations for invalid URLs.

This CL cancels navigation actions for invalid URLs, loading about:blank
instead.  This matches the behavior in content/.

BUG=627581, 651854
==========

to

==========
Don't allow link navigations for invalid URLs.

This CL cancels navigation actions for invalid URLs, loading about:blank
instead.  This matches the behavior in content/.

BUG=627581, 651854

Committed: https://crrev.com/8ad7f5ffc393f808323dd1d286cc00cc82161fc0
Cr-Commit-Position: refs/heads/master@{#423085}
==========

[commit-bot: I haz the power, 2016-10-05 06:12:54]

Patchset 3 (id:??) landed as
https://crrev.com/8ad7f5ffc393f808323dd1d286cc00cc82161fc0
Cr-Commit-Position: refs/heads/master@{#423085}