Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2725933006: Reduce use of elements/resolution_types in enqueuer. (Closed)

Created:
3 years, 9 months ago by Johnni Winther
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : One more #

Total comments: 2

Patch Set 3 : Updated cf. comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -68 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 7 chunks +14 lines, -23 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/enqueuer.dart View 1 chunk +1 line, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/mirrors_data.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 1 2 3 chunks +13 lines, -21 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/codegen_world_builder.dart View 3 chunks +4 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/universe/resolution_world_builder.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 1 chunk +6 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/analyze_unused_dart2js_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 9 months ago (2017-03-03 10:21:10 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2725933006/diff/20001/pkg/compiler/lib/src/js_backend/runtime_types.dart File pkg/compiler/lib/src/js_backend/runtime_types.dart (right): https://codereview.chromium.org/2725933006/diff/20001/pkg/compiler/lib/src/js_backend/runtime_types.dart#newcode178 pkg/compiler/lib/src/js_backend/runtime_types.dart:178: ResolutionInterfaceType current = type; merge with previous line? ...
3 years, 9 months ago (2017-03-14 03:07:04 UTC) #3
Johnni Winther
Committed patchset #3 (id:40001) manually as 1edc68323ebd1247e84e41bf0a7c098370989c76 (presubmit successful).
3 years, 9 months ago (2017-03-14 17:25:24 UTC) #5
Johnni Winther
3 years, 9 months ago (2017-03-15 08:36:47 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2725933006/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/runtime_types.dart (right):

https://codereview.chromium.org/2725933006/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/runtime_types.dart:178: ResolutionInterfaceType
current = type;
On 2017/03/14 03:07:04, Siggi Cherem (dart-lang) wrote:
> merge with previous line? Or change the one above to InterfaceType?

Done.

Powered by Google App Engine
This is Rietveld 408576698