pkg/compiler/lib/src/js_backend/mirrors_data.dart - Issue 2725933006: Reduce use of elements/resolution_types in enqueuer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/mirrors_data.dart

Issue 2725933006: Reduce use of elements/resolution_types in enqueuer. (Closed)

Patch Set: Updated cf. comment. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/mirrors_data.dart

diff --git a/pkg/compiler/lib/src/js_backend/mirrors_data.dart b/pkg/compiler/lib/src/js_backend/mirrors_data.dart

index 54236f802dbae68a9ea462bf709d1b24cc92afd2..651f436c8e6498d77bb6f678f2ec7004d9fa91c2 100644

--- a/pkg/compiler/lib/src/js_backend/mirrors_data.dart

+++ b/pkg/compiler/lib/src/js_backend/mirrors_data.dart

@@ -312,7 +312,7 @@ class MirrorsData {

if (memberNames.contains(member.name)) {

// TODO(20993): find out why this assertion fails.

// assert(invariant(member.element,

- // resolution.hasBeenProcessed(member.element)));

+ // worldBuilder.isMemberUsed(member.element)));

if (worldBuilder.isMemberUsed(member.element)) {

reflectableMembers.add(member.element);

}