Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: tests/compiler/dart2js/analyze_unused_dart2js_test.dart

Issue 2725933006: Reduce use of elements/resolution_types in enqueuer. (Closed)
Patch Set: Updated cf. comment. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analyze_unused_dart2js; 5 library analyze_unused_dart2js;
6 6
7 import 'package:async_helper/async_helper.dart'; 7 import 'package:async_helper/async_helper.dart';
8 8
9 import 'package:compiler/src/compiler.dart'; 9 import 'package:compiler/src/compiler.dart';
10 import 'package:compiler/src/diagnostics/messages.dart'; 10 import 'package:compiler/src/diagnostics/messages.dart';
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 const {}, // WHITE_LIST 54 const {}, // WHITE_LIST
55 mode: AnalysisMode.TREE_SHAKING, 55 mode: AnalysisMode.TREE_SHAKING,
56 checkResults: checkResults)); 56 checkResults: checkResults));
57 } 57 }
58 58
59 bool checkResults(Compiler compiler, CollectingDiagnosticHandler handler) { 59 bool checkResults(Compiler compiler, CollectingDiagnosticHandler handler) {
60 var helperUri = 60 var helperUri =
61 currentDirectory.resolve('pkg/compiler/lib/src/helpers/helpers.dart'); 61 currentDirectory.resolve('pkg/compiler/lib/src/helpers/helpers.dart');
62 void checkLive(member) { 62 void checkLive(member) {
63 if (member.isFunction) { 63 if (member.isFunction) {
64 if (compiler.enqueuer.resolution.hasBeenProcessed(member)) { 64 if (compiler.resolutionWorldBuilder.isMemberUsed(member)) {
65 compiler.reporter.reportHintMessage(member, MessageKind.GENERIC, 65 compiler.reporter.reportHintMessage(member, MessageKind.GENERIC,
66 {'text': "Helper function in production code '$member'."}); 66 {'text': "Helper function in production code '$member'."});
67 } 67 }
68 } else if (member.isClass) { 68 } else if (member.isClass) {
69 if (member.isResolved) { 69 if (member.isResolved) {
70 compiler.reporter.reportHintMessage(member, MessageKind.GENERIC, 70 compiler.reporter.reportHintMessage(member, MessageKind.GENERIC,
71 {'text': "Helper class in production code '$member'."}); 71 {'text': "Helper class in production code '$member'."});
72 } else { 72 } else {
73 member.forEachLocalMember(checkLive); 73 member.forEachLocalMember(checkLive);
74 } 74 }
75 } else if (member.isTypedef) { 75 } else if (member.isTypedef) {
76 if (member.isResolved) { 76 if (member.isResolved) {
77 compiler.reporter.reportHintMessage(member, MessageKind.GENERIC, 77 compiler.reporter.reportHintMessage(member, MessageKind.GENERIC,
78 {'text': "Helper typedef in production code '$member'."}); 78 {'text': "Helper typedef in production code '$member'."});
79 } 79 }
80 } 80 }
81 } 81 }
82 82
83 compiler.libraryLoader.lookupLibrary(helperUri).forEachLocalMember(checkLive); 83 compiler.libraryLoader.lookupLibrary(helperUri).forEachLocalMember(checkLive);
84 return handler.checkResults(); 84 return handler.checkResults();
85 } 85 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/universe/world_builder.dart ('k') | tests/compiler/dart2js/resolver_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698