Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: pkg/compiler/lib/src/universe/resolution_world_builder.dart

Issue 2725933006: Reduce use of elements/resolution_types in enqueuer. (Closed)
Patch Set: Updated cf. comment. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/universe/resolution_world_builder.dart
diff --git a/pkg/compiler/lib/src/universe/resolution_world_builder.dart b/pkg/compiler/lib/src/universe/resolution_world_builder.dart
index 7d9b5898d172de85500c1e1e7458b50197f940a2..86e9b093894cb508b6a0b6b5e7ae6efceed3795e 100644
--- a/pkg/compiler/lib/src/universe/resolution_world_builder.dart
+++ b/pkg/compiler/lib/src/universe/resolution_world_builder.dart
@@ -394,7 +394,7 @@ class ElementResolutionWorldBuilder implements ResolutionEnqueuerWorldBuilder {
///
/// See [directlyInstantiatedClasses].
// TODO(johnniwinther): Improve semantic precision.
- Iterable<ResolutionDartType> get instantiatedTypes {
+ Iterable<InterfaceType> get instantiatedTypes {
Set<ResolutionInterfaceType> types = new Set<ResolutionInterfaceType>();
getInstantiationMap().forEach((_, InstantiationInfo info) {
if (info.instantiationMap != null) {
@@ -600,14 +600,14 @@ class ElementResolutionWorldBuilder implements ResolutionEnqueuerWorldBuilder {
return constraints.addReceiverConstraint(mask);
}
- ResolutionDartType registerIsCheck(ResolutionDartType type) {
+ void registerIsCheck(ResolutionDartType type) {
type.computeUnaliased(_resolution);
type = type.unaliased;
// Even in checked mode, type annotations for return type and argument
// types do not imply type checks, so there should never be a check
// against the type variable of a typedef.
+ assert(!type.isTypeVariable || !type.element.enclosingElement.isTypedef);
isChecks.add(type);
- return type;
}
void registerStaticUse(StaticUse staticUse, MemberUsedCallback memberUsed) {
« no previous file with comments | « pkg/compiler/lib/src/universe/codegen_world_builder.dart ('k') | pkg/compiler/lib/src/universe/world_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698