Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 2725803006: Move standard transition handling logic into separate function (Closed)

Created:
3 years, 9 months ago by alancutter (OOO until 2018)
Modified:
3 years, 9 months ago
Reviewers:
Eric Willigers
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move standard transition handling logic into separate function This patch refactors standard CSS property transition calculation to be isolated to calculateTransitionUpdateForStandardProperty(). This is in preparation for introducing another separate function called calculateTransitionUpdateForCustomProperty() that enables CSS Transitions on registered custom properties. This patch is a refactor and does not change behaviour. BUG=671904 Review-Url: https://codereview.chromium.org/2725803006 Cr-Commit-Position: refs/heads/master@{#455702} Committed: https://chromium.googlesource.com/chromium/src/+/c173bd4d5a794e2f83edf3ff860e98a1199c0510

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : fixReference #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -79 lines) Patch
M third_party/WebKit/Source/core/animation/css/CSSAnimations.h View 1 2 1 chunk +19 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp View 1 4 chunks +85 lines, -70 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
alancutter (OOO until 2018)
3 years, 9 months ago (2017-03-03 08:37:14 UTC) #3
Eric Willigers
lgtm
3 years, 9 months ago (2017-03-08 03:59:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725803006/20001
3 years, 9 months ago (2017-03-09 03:35:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/325424)
3 years, 9 months ago (2017-03-09 04:19:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725803006/40001
3 years, 9 months ago (2017-03-09 07:00:05 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 08:52:40 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c173bd4d5a794e2f83edf3ff860e...

Powered by Google App Engine
This is Rietveld 408576698