Add registered custom property wrapping support to CSSAnimatableValueFactory

Add registered custom property wrapping support to CSSAnimatableValueFactory

This patch enables AnimatableValues to be created from registered
custom property CSSValues. This does not enable interpolation of
the registered custom properties via AnimatableValues, this is only
required because AnimatableValues are still used by CSSTransitions
as a way of testing equality between animation keyframes and
computed style values.

This patch is a refactor and does not change behaviour.

BUG=671904
Review-Url: https://codereview.chromium.org/2723883005
Cr-Commit-Position: refs/heads/master@{#456023}
Committed: https://chromium.googlesource.com/chromium/src/+/3cfa3f891108a0b22cdf04122cbde1f85d9e87e7

[alancutter (OOO until 2018), 2017-03-03 08:40:55]

Description was changed from

==========
[WIP] Add registered custom property support to CSSAnimatableValueFactory

BUG=671904
==========

to

==========
Add registered custom property wrapping support to CSSAnimatableValueFactory

This patch enables AnimatableValues to be created from registered
custom property CSSValues. This does not enable interpolation of
the registered custom properties via AnimatableValues, this is only
required because AnimatableValues are still used by CSSTransitions
as a way of testing equality between animation keyframes and
computed style values.

This patch is a refactor and does not change behaviour.

BUG=671904
==========

[alancutter (OOO until 2018), 2017-03-03 08:40:56]

alancutter@chromium.org changed reviewers:
+ ericwilligers@chromium.org

[Eric Willigers, 2017-03-04 04:16:31]

https://codereview.chromium.org/2723883005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/animatable/AnimatableUnknown.h
(right):

https://codereview.chromium.org/2723883005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/animatable/AnimatableUnknown.h:81:
return equalTo(value);
Why the change from not equals to equals?

[alancutter (OOO until 2018), 2017-03-05 23:23:57]

https://codereview.chromium.org/2723883005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/animatable/AnimatableUnknown.h
(right):

https://codereview.chromium.org/2723883005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/animatable/AnimatableUnknown.h:81:
return equalTo(value);
On 2017/03/04 at 04:16:31, Eric Willigers wrote:
> Why the change from not equals to equals?

Whoops, fixed.

[Eric Willigers, 2017-03-08 03:53:37]

lgtm

[alancutter (OOO until 2018), 2017-03-09 03:34:58]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 03:35:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 03:37:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 03:37:10]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alancutter (OOO until 2018), 2017-03-10 02:12:56]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2017-03-10 02:12:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
ericwilligers@chromium.org
Link to the patchset: https://codereview.chromium.org/2723883005/#ps60001
(title: "Rebased")

[commit-bot: I haz the power, 2017-03-10 02:13:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 02:23:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 02:23:13]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[alancutter (OOO until 2018), 2017-03-10 02:24:55]

alancutter@chromium.org changed reviewers:
+ meade@chromium.org

[alancutter (OOO until 2018), 2017-03-10 02:25:11]

+meade for changes to ComputedStyle.

[meade_UTC10, 2017-03-10 04:15:43]

lgtm

[alancutter (OOO until 2018), 2017-03-10 08:14:43]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2017-03-10 08:15:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 08:19:21]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489133683301860,
"parent_rev": "51a7f57411aada6b19a573f66df84f58599249d8", "commit_rev":
"3cfa3f891108a0b22cdf04122cbde1f85d9e87e7"}

[commit-bot: I haz the power, 2017-03-10 08:20:00]

Description was changed from

==========
Add registered custom property wrapping support to CSSAnimatableValueFactory

This patch enables AnimatableValues to be created from registered
custom property CSSValues. This does not enable interpolation of
the registered custom properties via AnimatableValues, this is only
required because AnimatableValues are still used by CSSTransitions
as a way of testing equality between animation keyframes and
computed style values.

This patch is a refactor and does not change behaviour.

BUG=671904
==========

to

==========
Add registered custom property wrapping support to CSSAnimatableValueFactory

This patch enables AnimatableValues to be created from registered
custom property CSSValues. This does not enable interpolation of
the registered custom properties via AnimatableValues, this is only
required because AnimatableValues are still used by CSSTransitions
as a way of testing equality between animation keyframes and
computed style values.

This patch is a refactor and does not change behaviour.

BUG=671904

Review-Url: https://codereview.chromium.org/2723883005
Cr-Commit-Position: refs/heads/master@{#456023}
Committed:
https://chromium.googlesource.com/chromium/src/+/3cfa3f891108a0b22cdf04122cbd...
==========

[commit-bot: I haz the power, 2017-03-10 08:20:01]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3cfa3f891108a0b22cdf04122cbd...