Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: third_party/WebKit/Source/core/animation/css/CSSAnimations.h

Issue 2725803006: Move standard transition handling logic into separate function (Closed)
Patch Set: fixReference Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/animation/css/CSSAnimations.h
diff --git a/third_party/WebKit/Source/core/animation/css/CSSAnimations.h b/third_party/WebKit/Source/core/animation/css/CSSAnimations.h
index 8e02b8e143558733b17b56551691d8d644e720cf..54715efbbe25490663c07000912199a41071e74b 100644
--- a/third_party/WebKit/Source/core/animation/css/CSSAnimations.h
+++ b/third_party/WebKit/Source/core/animation/css/CSSAnimations.h
@@ -154,15 +154,25 @@ class CSSAnimations final {
ActiveInterpolationsMap m_previousActiveInterpolationsForAnimations;
- static void calculateTransitionUpdateForProperty(
- const PropertyHandle&,
- const CSSTransitionData&,
- size_t transitionIndex,
- const ComputedStyle& oldStyle,
- const ComputedStyle&,
- const TransitionMap* activeTransitions,
- CSSAnimationUpdate&,
- const Element*);
+ struct TransitionUpdateState {
+ STACK_ALLOCATED();
+ CSSAnimationUpdate& update;
+ Member<const Element> animatingElement;
+ const ComputedStyle& oldStyle;
+ const ComputedStyle& style;
+ const TransitionMap* activeTransitions;
+ std::bitset<numCSSProperties>& listedProperties;
+ const CSSTransitionData& transitionData;
+ };
+
+ static void calculateTransitionUpdateForStandardProperty(
+ TransitionUpdateState&,
+ const CSSTransitionData::TransitionProperty&,
+ size_t transitionIndex);
+
+ static void calculateTransitionUpdateForProperty(TransitionUpdateState&,
+ const PropertyHandle&,
+ size_t transitionIndex);
static void calculateAnimationActiveInterpolations(
CSSAnimationUpdate&,
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698