Reland of [test] Speculatively remove local-tests from archive

Reland of [test] Speculatively remove local-tests from archive (patchset #1 id:1 of https://codereview.chromium.org/2640223003/ )

Reason for revert:
With the Windows bots fixed in https://chromium-review.googlesource.com/445786 , this should be good to reland. Thanks, Michael!

Original issue's description:
> Revert of [test] Speculatively remove local-tests from archive (patchset #2 id:20001 of https://codereview.chromium.org/2643983002/ )
> 
> Reason for revert:
> Breaks all windows bots:
> https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds/6811
> 
> Original issue's description:
> > [test] Remove local-tests from test262 archive and add to .isolate
> > 
> > This might help fix the bots, which are broken in e.g.,
> > https://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/builds/14011
> > 
> > The archive was added in order to transmit test262 tests more rapidly.
> > It doesn't serve much of a purpose for local-tests. I naively added
> > local-tests there out of symmetry. However, the BUILD.gn file does not
> > regenerate an archive when files are only deleted and not added or
> > changed. Since the performance concern is not present for the small
> > volume of local-tests, this patch reverts to the more normal mechanism
> > for sending over dependencies, with test262.isolate.
> > 
> > R=adamk
> > 
> > Review-Url: https://codereview.chromium.org/2643983002
> > Cr-Commit-Position: refs/heads/master@{#42485}
> > Committed: https://chromium.googlesource.com/v8/v8/+/9f545ea96f18b7036ac6ec43e359d63f41c3686a
> 
> TBR=adamk@chromium.org,littledan@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> 
> Review-Url: https://codereview.chromium.org/2640223003
> Cr-Commit-Position: refs/heads/master@{#42491}
> Committed: https://chromium.googlesource.com/v8/v8/+/4ffe0850dbb238dca4c1e2d14fb2984442a1fa24

TBR=adamk@chromium.org,machenbach@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2725643002
Cr-Commit-Position: refs/heads/master@{#43488}
Committed: https://chromium.googlesource.com/v8/v8/+/a48d7ce22668766dfc3290677ce27944c858229a

[Dan Ehrenberg, 2017-02-28 13:41:58]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2017-02-28 13:41:58]

Created Reland of [test] Speculatively remove local-tests from archive

[commit-bot: I haz the power, 2017-02-28 13:42:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Achenbach, 2017-02-28 13:51:30]

lgtm

[commit-bot: I haz the power, 2017-02-28 14:08:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 14:08:53]

Failed to apply patch for test/test262/test262.isolate:
While running git apply --index -p1;
  error: patch failed: test/test262/test262.isolate:9
  error: test/test262/test262.isolate: patch does not apply

Patch:       test/test262/test262.isolate
Index: test/test262/test262.isolate
diff --git a/test/test262/test262.isolate b/test/test262/test262.isolate
index
4e1419030efd7408d767600e86083be88ad7bebc..ab70e4a83b335f7483afdbd6c40a5f045b65f4bc
100644
--- a/test/test262/test262.isolate
+++ b/test/test262/test262.isolate
@@ -9,6 +9,7 @@
       'harness-adapt.js',
       'test262.status',
       'testcfg.py',
+      'local-tests/',
     ],
   },
   'includes': [

[Dan Ehrenberg, 2017-02-28 14:15:59]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2017-02-28 14:16:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2725643002/#ps100001
(title: "Reland of [test] Speculatively remove local-tests from archive
(patchset #1 id:1 of https://coderev…")

[commit-bot: I haz the power, 2017-02-28 14:16:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 14:43:17]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1488291359810520,
"parent_rev": "a35616e32425b2ff9d044bdc705ccc3542077b51", "commit_rev":
"a48d7ce22668766dfc3290677ce27944c858229a"}

[commit-bot: I haz the power, 2017-02-28 14:43:21]

Description was changed from

==========
Reland of [test] Speculatively remove local-tests from archive (patchset #1 id:1
of https://codereview.chromium.org/2640223003/ )

Reason for revert:
With the Windows bots fixed in https://chromium-review.googlesource.com/445786 ,
this should be good to reland. Thanks, Michael!

Original issue's description:
> Revert of [test] Speculatively remove local-tests from archive (patchset #2
id:20001 of https://codereview.chromium.org/2643983002/ )
> 
> Reason for revert:
> Breaks all windows bots:
>
https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds...
> 
> Original issue's description:
> > [test] Remove local-tests from test262 archive and add to .isolate
> > 
> > This might help fix the bots, which are broken in e.g.,
> >
https://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bu...
> > 
> > The archive was added in order to transmit test262 tests more rapidly.
> > It doesn't serve much of a purpose for local-tests. I naively added
> > local-tests there out of symmetry. However, the BUILD.gn file does not
> > regenerate an archive when files are only deleted and not added or
> > changed. Since the performance concern is not present for the small
> > volume of local-tests, this patch reverts to the more normal mechanism
> > for sending over dependencies, with test262.isolate.
> > 
> > R=adamk
> > 
> > Review-Url: https://codereview.chromium.org/2643983002
> > Cr-Commit-Position: refs/heads/master@{#42485}
> > Committed:
https://chromium.googlesource.com/v8/v8/+/9f545ea96f18b7036ac6ec43e359d63f41c...
> 
> TBR=adamk@chromium.org,littledan@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> 
> Review-Url: https://codereview.chromium.org/2640223003
> Cr-Commit-Position: refs/heads/master@{#42491}
> Committed:
https://chromium.googlesource.com/v8/v8/+/4ffe0850dbb238dca4c1e2d14fb2984442a...

TBR=adamk@chromium.org,machenbach@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
==========

to

==========
Reland of [test] Speculatively remove local-tests from archive (patchset #1 id:1
of https://codereview.chromium.org/2640223003/ )

Reason for revert:
With the Windows bots fixed in https://chromium-review.googlesource.com/445786 ,
this should be good to reland. Thanks, Michael!

Original issue's description:
> Revert of [test] Speculatively remove local-tests from archive (patchset #2
id:20001 of https://codereview.chromium.org/2643983002/ )
> 
> Reason for revert:
> Breaks all windows bots:
>
https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds...
> 
> Original issue's description:
> > [test] Remove local-tests from test262 archive and add to .isolate
> > 
> > This might help fix the bots, which are broken in e.g.,
> >
https://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bu...
> > 
> > The archive was added in order to transmit test262 tests more rapidly.
> > It doesn't serve much of a purpose for local-tests. I naively added
> > local-tests there out of symmetry. However, the BUILD.gn file does not
> > regenerate an archive when files are only deleted and not added or
> > changed. Since the performance concern is not present for the small
> > volume of local-tests, this patch reverts to the more normal mechanism
> > for sending over dependencies, with test262.isolate.
> > 
> > R=adamk
> > 
> > Review-Url: https://codereview.chromium.org/2643983002
> > Cr-Commit-Position: refs/heads/master@{#42485}
> > Committed:
https://chromium.googlesource.com/v8/v8/+/9f545ea96f18b7036ac6ec43e359d63f41c...
> 
> TBR=adamk@chromium.org,littledan@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> 
> Review-Url: https://codereview.chromium.org/2640223003
> Cr-Commit-Position: refs/heads/master@{#42491}
> Committed:
https://chromium.googlesource.com/v8/v8/+/4ffe0850dbb238dca4c1e2d14fb2984442a...

TBR=adamk@chromium.org,machenbach@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2725643002
Cr-Commit-Position: refs/heads/master@{#43488}
Committed:
https://chromium.googlesource.com/v8/v8/+/a48d7ce22668766dfc3290677ce27944c85...
==========

[commit-bot: I haz the power, 2017-02-28 14:43:22]

Committed patchset #2 (id:100001) as
https://chromium.googlesource.com/v8/v8/+/a48d7ce22668766dfc3290677ce27944c85...