Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2640223003: Revert of [test] Speculatively remove local-tests from archive (Closed)

Created:
3 years, 11 months ago by Michael Achenbach
Modified:
3 years, 11 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-reviews_googlegroups.com, machenbach
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [test] Speculatively remove local-tests from archive (patchset #2 id:20001 of https://codereview.chromium.org/2643983002/ ) Reason for revert: Breaks all windows bots: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds/6811 Original issue's description: > [test] Remove local-tests from test262 archive and add to .isolate > > This might help fix the bots, which are broken in e.g., > https://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/builds/14011 > > The archive was added in order to transmit test262 tests more rapidly. > It doesn't serve much of a purpose for local-tests. I naively added > local-tests there out of symmetry. However, the BUILD.gn file does not > regenerate an archive when files are only deleted and not added or > changed. Since the performance concern is not present for the small > volume of local-tests, this patch reverts to the more normal mechanism > for sending over dependencies, with test262.isolate. > > R=adamk > > Review-Url: https://codereview.chromium.org/2643983002 > Cr-Commit-Position: refs/heads/master@{#42485} > Committed: https://chromium.googlesource.com/v8/v8/+/9f545ea96f18b7036ac6ec43e359d63f41c3686a TBR=adamk@chromium.org,littledan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2640223003 Cr-Commit-Position: refs/heads/master@{#42491} Committed: https://chromium.googlesource.com/v8/v8/+/4ffe0850dbb238dca4c1e2d14fb2984442a1fa24

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M test/test262/archive.py View 1 chunk +1 line, -0 lines 0 comments Download
M test/test262/list.py View 1 chunk +2 lines, -1 line 0 comments Download
M test/test262/test262.isolate View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Achenbach
Created Revert of [test] Speculatively remove local-tests from archive
3 years, 11 months ago (2017-01-19 07:58:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640223003/1
3 years, 11 months ago (2017-01-19 07:58:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/4ffe0850dbb238dca4c1e2d14fb2984442a1fa24
3 years, 11 months ago (2017-01-19 07:58:49 UTC) #6
adamk
lgtm, sorry about the breakage: we were trying to fix an already busted situation. Also ...
3 years, 11 months ago (2017-01-19 17:30:23 UTC) #7
Dan Ehrenberg
3 years, 9 months ago (2017-02-28 13:41:57 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2725643002/ by littledan@chromium.org.

The reason for reverting is: With the Windows bots fixed in
https://chromium-review.googlesource.com/445786 , this should be good to reland.
Thanks, Michael!.

Powered by Google App Engine
This is Rietveld 408576698