Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
3 years, 11 months ago by Dan Ehrenberg Modified:
3 years, 11 months ago Reviewers:
adamk CC:
v8-reviews_googlegroups.com, machenbach Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[test] Remove local-tests from test262 archive and add to .isolate
This might help fix the bots, which are broken in e.g.,
https://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/builds/14011
The archive was added in order to transmit test262 tests more rapidly.
It doesn't serve much of a purpose for local-tests. I naively added
local-tests there out of symmetry. However, the BUILD.gn file does not
regenerate an archive when files are only deleted and not added or
changed. Since the performance concern is not present for the small
volume of local-tests, this patch reverts to the more normal mechanism
for sending over dependencies, with test262.isolate.
R=adamk
Review-Url: https://codereview.chromium.org/2643983002
Cr-Commit-Position: refs/heads/master@{#42485}
Committed: https://chromium.googlesource.com/v8/v8/+/9f545ea96f18b7036ac6ec43e359d63f41c3686a
Patch Set 1 #Patch Set 2 : Add to isolate #
Created: 3 years, 11 months ago
Messages
Total messages: 18 (12 generated)
The CQ bit was checked by littledan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/19563) v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)
The CQ bit was checked by littledan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
This lgtm with an updated CL description mentioning that local-tests are now pushed the same was as anything else.
Description was changed from ========== [test] Speculatively remove local-tests from archive This might help fix the bots, which are broken in e.g., https://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bu... R=adamk ========== to ========== [test] Remove local-tests from test262 archive and add to .isolate This might help fix the bots, which are broken in e.g., https://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bu... The archive was added in order to transmit test262 tests more rapidly. It doesn't serve much of a purpose for local-tests. I naively added local-tests there out of symmetry. However, the BUILD.gn file does not regenerate an archive when files are only deleted and not added or changed. Since the performance concern is not present for the small volume of local-tests, this patch reverts to the more normal mechanism for sending over dependencies, with test262.isolate. R=adamk ==========
The CQ bit was unchecked by littledan@chromium.org
The CQ bit was checked by littledan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484787789850650,
"parent_rev": "89b7a4d7d0a2539c8e3d2422f90c6f6fbdecd0a6", "commit_rev":
"9f545ea96f18b7036ac6ec43e359d63f41c3686a"}
Message was sent while issue was closed.
Description was changed from ========== [test] Remove local-tests from test262 archive and add to .isolate This might help fix the bots, which are broken in e.g., https://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bu... The archive was added in order to transmit test262 tests more rapidly. It doesn't serve much of a purpose for local-tests. I naively added local-tests there out of symmetry. However, the BUILD.gn file does not regenerate an archive when files are only deleted and not added or changed. Since the performance concern is not present for the small volume of local-tests, this patch reverts to the more normal mechanism for sending over dependencies, with test262.isolate. R=adamk ========== to ========== [test] Remove local-tests from test262 archive and add to .isolate This might help fix the bots, which are broken in e.g., https://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bu... The archive was added in order to transmit test262 tests more rapidly. It doesn't serve much of a purpose for local-tests. I naively added local-tests there out of symmetry. However, the BUILD.gn file does not regenerate an archive when files are only deleted and not added or changed. Since the performance concern is not present for the small volume of local-tests, this patch reverts to the more normal mechanism for sending over dependencies, with test262.isolate. R=adamk Review-Url: https://codereview.chromium.org/2643983002 Cr-Commit-Position: refs/heads/master@{#42485} Committed: https://chromium.googlesource.com/v8/v8/+/9f545ea96f18b7036ac6ec43e359d63f41c... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/9f545ea96f18b7036ac6ec43e359d63f41c...
Message was sent while issue was closed.
Description was changed from ========== [test] Remove local-tests from test262 archive and add to .isolate This might help fix the bots, which are broken in e.g., https://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bu... The archive was added in order to transmit test262 tests more rapidly. It doesn't serve much of a purpose for local-tests. I naively added local-tests there out of symmetry. However, the BUILD.gn file does not regenerate an archive when files are only deleted and not added or changed. Since the performance concern is not present for the small volume of local-tests, this patch reverts to the more normal mechanism for sending over dependencies, with test262.isolate. R=adamk Review-Url: https://codereview.chromium.org/2643983002 Cr-Commit-Position: refs/heads/master@{#42485} Committed: https://chromium.googlesource.com/v8/v8/+/9f545ea96f18b7036ac6ec43e359d63f41c... ========== to ========== [test] Remove local-tests from test262 archive and add to .isolate This might help fix the bots, which are broken in e.g., https://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bu... The archive was added in order to transmit test262 tests more rapidly. It doesn't serve much of a purpose for local-tests. I naively added local-tests there out of symmetry. However, the BUILD.gn file does not regenerate an archive when files are only deleted and not added or changed. Since the performance concern is not present for the small volume of local-tests, this patch reverts to the more normal mechanism for sending over dependencies, with test262.isolate. R=adamk Review-Url: https://codereview.chromium.org/2643983002 Cr-Commit-Position: refs/heads/master@{#42485} Committed: https://chromium.googlesource.com/v8/v8/+/9f545ea96f18b7036ac6ec43e359d63f41c... ==========
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2640223003/ by machenbach@chromium.org. The reason for reverting is: Breaks all windows bots: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds....
Message was sent while issue was closed.
On 2017/01/19 07:58:29, Michael Achenbach wrote: > A revert of this CL (patchset #2 id:20001) has been created in > https://codereview.chromium.org/2640223003/ by mailto:machenbach@chromium.org. > > The reason for reverting is: Breaks all windows bots: > https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds.... I think the explanation is as simple as us not running test262 on windows. Stems from the times were the tests gave us capacity and cycle time problems. But now times are different and this should be fixed. Could you file me a ticket, so I don't forget it?
Message was sent while issue was closed.
On 2017/01/19 21:32:23, Michael Achenbach wrote: > On 2017/01/19 07:58:29, Michael Achenbach wrote: > > A revert of this CL (patchset #2 id:20001) has been created in > > https://codereview.chromium.org/2640223003/ by mailto:machenbach@chromium.org. > > > > The reason for reverting is: Breaks all windows bots: > > > https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds.... > > I think the explanation is as simple as us not running test262 on windows. Stems > from the times were the tests gave us capacity and cycle time problems. But now > times are different and this should be fixed. Could you file me a ticket, so I > don't forget it? Sure, filed https://bugs.chromium.org/p/v8/issues/detail?id=5872 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
