The WebVTT 'line' settings should be parsed as a float

The WebVTT 'line' settings should be parsed as a float

Per https://w3c.github.io/webvtt/#parse-the-webvtt-cue-settings .
Negative zero is transformed to positive zero.

Also make valid percentages outside of [0, 100] fail quicker.

BUG=697869
Review-Url: https://codereview.chromium.org/2725313002
Cr-Commit-Position: refs/heads/master@{#454587}
Committed: https://chromium.googlesource.com/chromium/src/+/8c2c0ae635af66f017c084641684d054863802a8

[fs, 2017-03-03 12:35:23]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 12:35:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-03-03 12:38:49]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 12:38:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-03-03 13:20:11]

Description was changed from

==========
The WebVTT 'line' settings should be parsed as a float

Per https://w3c.github.io/webvtt/#parse-the-webvtt-cue-settings .

Also make valid percentages ouside of [0, 100] fail quicker.

BUG=697869
==========

to

==========
The WebVTT 'line' settings should be parsed as a float

Per https://w3c.github.io/webvtt/#parse-the-webvtt-cue-settings .
Negative zero is transformed to positive zero.

Also make valid percentages ouside of [0, 100] fail quicker.

BUG=697869
==========

[fs, 2017-03-03 13:20:27]

Description was changed from

==========
The WebVTT 'line' settings should be parsed as a float

Per https://w3c.github.io/webvtt/#parse-the-webvtt-cue-settings .
Negative zero is transformed to positive zero.

Also make valid percentages ouside of [0, 100] fail quicker.

BUG=697869
==========

to

==========
The WebVTT 'line' settings should be parsed as a float

Per https://w3c.github.io/webvtt/#parse-the-webvtt-cue-settings .
Negative zero is transformed to positive zero.

Also make valid percentages outside of [0, 100] fail quicker.

BUG=697869
==========

[fs, 2017-03-03 14:06:50]

fs@opera.com changed reviewers:
+ foolip@chromium.org

[commit-bot: I haz the power, 2017-03-03 14:19:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 14:19:16]

Dry run: This issue passed the CQ dry run.

[foolip, 2017-03-03 15:13:58]

lgtm % -0, which I guess is NaN unless lgtm is a Symbol, in which case it throws
TypeError.

https://codereview.chromium.org/2725313002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp (right):

https://codereview.chromium.org/2725313002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp:1009: // 5. Interpret
linepos as a (potentially signed) real number, and
Hmm, strictly speaking I guess this is ambiguous for input "-0", and similarly
returning -0 when the input is "0" could be considered correct. Care to file a
spec issue to make this unambiguous?

Also, I don't see any added test, was this already covered?

[fs, 2017-03-03 15:21:04]

https://codereview.chromium.org/2725313002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp (right):

https://codereview.chromium.org/2725313002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp:1009: // 5. Interpret
linepos as a (potentially signed) real number, and
On 2017/03/03 at 15:13:57, foolip wrote:
> Hmm, strictly speaking I guess this is ambiguous for input "-0", and similarly
returning -0 when the input is "0" could be considered correct. Care to file a
spec issue to make this unambiguous?

Discussed this with the spec editor earlier today =) -
https://github.com/w3c/webvtt/issues/338 - and the current suggestion is to use
HTML's float microsyntax. And that should be consistent with what I've
implemented here.
 
> Also, I don't see any added test, was this already covered?

Yes, settings-line.vtt has a cue with a line:-0

[foolip, 2017-03-03 15:25:35]

https://codereview.chromium.org/2725313002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp (right):

https://codereview.chromium.org/2725313002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp:1009: // 5. Interpret
linepos as a (potentially signed) real number, and
On 2017/03/03 15:21:03, fs wrote:
> On 2017/03/03 at 15:13:57, foolip wrote:
> > Hmm, strictly speaking I guess this is ambiguous for input "-0", and
similarly
> returning -0 when the input is "0" could be considered correct. Care to file a
> spec issue to make this unambiguous?
> 
> Discussed this with the spec editor earlier today =) -
> https://github.com/w3c/webvtt/issues/338 - and the current suggestion is to
use
> HTML's float microsyntax. And that should be consistent with what I've
> implemented here.
>  
> > Also, I don't see any added test, was this already covered?
> 
> Yes, settings-line.vtt has a cue with a line:-0

Yay :)

[fs, 2017-03-03 15:32:01]

On 2017/03/03 at 15:25:35, foolip wrote:
>
https://codereview.chromium.org/2725313002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp (right):
> 
>
https://codereview.chromium.org/2725313002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp:1009: // 5. Interpret
linepos as a (potentially signed) real number, and
> On 2017/03/03 15:21:03, fs wrote:
> > On 2017/03/03 at 15:13:57, foolip wrote:
> > > Hmm, strictly speaking I guess this is ambiguous for input "-0", and
similarly
> > returning -0 when the input is "0" could be considered correct. Care to file
a
> > spec issue to make this unambiguous?
> > 
> > Discussed this with the spec editor earlier today =) -
> > https://github.com/w3c/webvtt/issues/338 - and the current suggestion is to
use
> > HTML's float microsyntax. And that should be consistent with what I've
> > implemented here.

Actually, we probably don't handle overflows "correctly" per the suggested spec
text... #lovethyedgecase

[fs, 2017-03-03 15:32:25]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2017-03-03 15:32:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 15:37:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488555145218000,
"parent_rev": "47cf44bdd2b1242e75a2bb5945a9412c41f4073d", "commit_rev":
"8c2c0ae635af66f017c084641684d054863802a8"}

[commit-bot: I haz the power, 2017-03-03 15:38:18]

Description was changed from

==========
The WebVTT 'line' settings should be parsed as a float

Per https://w3c.github.io/webvtt/#parse-the-webvtt-cue-settings .
Negative zero is transformed to positive zero.

Also make valid percentages outside of [0, 100] fail quicker.

BUG=697869
==========

to

==========
The WebVTT 'line' settings should be parsed as a float

Per https://w3c.github.io/webvtt/#parse-the-webvtt-cue-settings .
Negative zero is transformed to positive zero.

Also make valid percentages outside of [0, 100] fail quicker.

BUG=697869

Review-Url: https://codereview.chromium.org/2725313002
Cr-Commit-Position: refs/heads/master@{#454587}
Committed:
https://chromium.googlesource.com/chromium/src/+/8c2c0ae635af66f017c084641684...
==========

[commit-bot: I haz the power, 2017-03-03 15:38:20]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8c2c0ae635af66f017c084641684...