third_party/WebKit/LayoutTests/media/track/track-webvtt-tc017-line-position.html - Issue 2725313002: The WebVTT 'line' settings should be parsed as a float

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-webvtt-tc017-line-position.html

Issue 2725313002: The WebVTT 'line' settings should be parsed as a float (Closed)

Patch Set: Updated expectations Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/opera/track/webvtt/parsing/support/settings-line.vtt ('k') | third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp » ('j') | third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>Tests cue line position from settings.</title>	2 <title>Tests cue line position from settings.</title>

3 <script src="track-helpers.js"></script>	3 <script src="track-helpers.js"></script>

4 <script src="../../resources/testharness.js"></script>	4 <script src="../../resources/testharness.js"></script>

5 <script src="../../resources/testharnessreport.js"></script>	5 <script src="../../resources/testharnessreport.js"></script>

6 <video>	6 <video>

7 <track src="captions-webvtt/tc017-line-position.vtt">	7 <track src="captions-webvtt/tc017-line-position.vtt">

8 <track src="captions-webvtt/tc017-line-position-bad.vtt">	8 <track src="captions-webvtt/tc017-line-position-bad.vtt">

9 </video>	9 </video>

10 <script>	10 <script>

(...skipping 31 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
42	42

43 assert_cues_match(video.textTracks[index].cues, expected);	43 assert_cues_match(video.textTracks[index].cues, expected);

44 }	44 }

45	45

46 function testTrackError(index) {	46 function testTrackError(index) {

47 var expected = [	47 var expected = [

48 { line : "auto", snapToLines : true },	48 { line : "auto", snapToLines : true },

49 { line : "auto", snapToLines : true },	49 { line : "auto", snapToLines : true },

50 { line : "auto", snapToLines : true },	50 { line : "auto", snapToLines : true },

51 { line : "auto", snapToLines : true },	51 { line : "auto", snapToLines : true },

52 { line : "auto", snapToLines : true },

53 { line : "auto", snapToLines : true }	52 { line : "auto", snapToLines : true }

54 ];	53 ];

55	54

56 assert_cues_match(video.textTracks[index].cues, expected);	55 assert_cues_match(video.textTracks[index].cues, expected);

57 }	56 }

58 });	57 });

59 </script>	58 </script>

OLD	NEW