third_party/WebKit/LayoutTests/media/track/captions-webvtt/tc017-line-position-bad.vtt - Issue 2725313002: The WebVTT 'line' settings should be parsed as a float

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/captions-webvtt/tc017-line-position-bad.vtt

Issue 2725313002: The WebVTT 'line' settings should be parsed as a float (Closed)

Patch Set: Updated expectations Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/track/opera/track/webvtt/parsing/001-expected.txt » ('j') | third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 WEBVTT	1 WEBVTT

2 Invalid positioning values (all settings are ignored).	2 Invalid positioning values (all settings are ignored).

3	3

4 1	4 1

5 00:00:00.000 --> 00:00:15.000 line:-0%	5 00:00:00.000 --> 00:00:15.000 line:-0%

6 Bear is Coming!!!!!	6 Bear is Coming!!!!!

7 Negative percentages are not allowed.	7 Negative percentages are not allowed.

8 Line position is ignored.	8 Line position is ignored.

9	9

10 00:00:15.500 --> 00:00:30.500 line:0.5

11 Bear is Coming!!!!!

12 Fractions of lines are not allowed.

13 Line position is ignored.

14

15 2	10 2

16 00:00:31.000 --> 00:00:45.500 line:+50%	11 00:00:31.000 --> 00:00:45.500 line:+50%

17 I said Bear is coming!!!!	12 I said Bear is coming!!!!

18 Non-numbers are not allowed.	13 Non-numbers are not allowed.

19 Line position is ignored.	14 Line position is ignored.

20	15

21 00:00:46.000 --> 00:01:00.500 line:+5	16 00:00:46.000 --> 00:01:00.500 line:+5

22 I said Bear is coming!!!!	17 I said Bear is coming!!!!

23 Plus sign is not allowed.	18 Plus sign is not allowed.

24 Line position is ignored.	19 Line position is ignored.

25	20

26 3	21 3

27 00:01:01.000 --> 00:01:30.000 line:10%0%	22 00:01:01.000 --> 00:01:30.000 line:10%0%

28 I said Bear is coming now!!!!	23 I said Bear is coming now!!!!

29 Doesn't parse into a percentage.	24 Doesn't parse into a percentage.

30 Line position is ignored.	25 Line position is ignored.

31	26

32 00:01:31.000 --> 00:02:00.500 line:-10l	27 00:01:31.000 --> 00:02:00.500 line:-10l

33 I said Bear is coming now!!!!	28 I said Bear is coming now!!!!

34 Doesn't parse into a number.	29 Doesn't parse into a number.

35 Line position is ignored.	30 Line position is ignored.

OLD	NEW