Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2725263002: Revert of Fix unit tests to enable them testing with the rAF aligned touch input. (Closed)

Created:
3 years, 9 months ago by dtapuska
Modified:
3 years, 9 months ago
Reviewers:
tdresser
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, dtapuska+chromiumwatch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, James Su
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix unit tests to enable them testing with the rAF aligned touch input. (patchset #3 id:40001 of https://codereview.chromium.org/2727683002/ ) Reason for revert: Rolling back passthrough event queue being enabled. Original issue's description: > Fix unit tests to enable them testing with the rAF aligned touch input. > > rAF aligned touch input enables a passthrough touch event queue and a > number of tests were testing the number of ACKs or messages sent. > Explicitly enable the tests so that it is independent of the actual feature > setting. In certain test cases run both the rAF enabled and disabled. For > tests where it doesn't really matter just enable it. Most of the changes > here are related to GestureScrollUpdate which then generates 2 messages > sent immediately (instead of 1 sent and 1 queued). > > BUG=642368 > > Review-Url: https://codereview.chromium.org/2727683002 > Cr-Commit-Position: refs/heads/master@{#454243} > Committed: https://chromium.googlesource.com/chromium/src/+/48e55aa69627f177a523bbf80f753454764ac2ac TBR=tdresser@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=642368 Review-Url: https://codereview.chromium.org/2725263002 Cr-Commit-Position: refs/heads/master@{#454463} Committed: https://chromium.googlesource.com/chromium/src/+/550f89fa439bba1a6aad2d2e343259bca9d0e731

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -300 lines) Patch
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 13 chunks +16 lines, -54 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 9 chunks +5 lines, -41 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 17 chunks +12 lines, -129 lines 0 comments Download
M content/renderer/input/input_event_filter_unittest.cc View 14 chunks +36 lines, -65 lines 0 comments Download
M content/renderer/input/input_handler_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/main_thread_event_queue_unittest.cc View 1 chunk +3 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dtapuska
Created Revert of Fix unit tests to enable them testing with the rAF aligned touch ...
3 years, 9 months ago (2017-03-03 01:54:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725263002/1
3 years, 9 months ago (2017-03-03 01:55:00 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 01:56:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/550f89fa439bba1a6aad2d2e3432...

Powered by Google App Engine
This is Rietveld 408576698