Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: content/browser/renderer_host/input/input_router_impl_unittest.cc

Issue 2725263002: Revert of Fix unit tests to enable them testing with the rAF aligned touch input. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/input/input_router_impl_unittest.cc
diff --git a/content/browser/renderer_host/input/input_router_impl_unittest.cc b/content/browser/renderer_host/input/input_router_impl_unittest.cc
index b3385b3c79e7692d12186b430375ffed38fe166e..82d4ae8e0d544c1ea709669f073886e11d3c6bed 100644
--- a/content/browser/renderer_host/input/input_router_impl_unittest.cc
+++ b/content/browser/renderer_host/input/input_router_impl_unittest.cc
@@ -144,7 +144,7 @@
class InputRouterImplTest : public testing::Test {
public:
- InputRouterImplTest(bool raf_aligned_touch = true) {
+ InputRouterImplTest(bool raf_aligned_touch = false) {
if (raf_aligned_touch) {
feature_list_.InitFromCommandLine(
features::kRafAlignedTouchInputEvents.name, "");
@@ -370,9 +370,9 @@
std::unique_ptr<TestBrowserContext> browser_context_;
};
-class InputRouterImplRafAlignedTouchDisabledTest : public InputRouterImplTest {
+class InputRouterImplRafAlignedTouchEnabledTest : public InputRouterImplTest {
public:
- InputRouterImplRafAlignedTouchDisabledTest() : InputRouterImplTest(false) {}
+ InputRouterImplRafAlignedTouchEnabledTest() : InputRouterImplTest(true) {}
};
TEST_F(InputRouterImplTest, CoalescesRangeSelection) {
@@ -800,7 +800,7 @@
}
// Tests that touch-events are queued properly.
-TEST_F(InputRouterImplRafAlignedTouchDisabledTest, TouchEventQueue) {
+TEST_F(InputRouterImplTest, TouchEventQueue) {
OnHasTouchEventHandlers(true);
PressTouchPoint(1, 1);
@@ -824,41 +824,6 @@
EXPECT_EQ(WebInputEvent::TouchStart,
ack_handler_->acked_touch_event().event.type());
EXPECT_EQ(1U, GetSentMessageCountAndResetSink());
-
- SendTouchEventACK(WebInputEvent::TouchMove, INPUT_EVENT_ACK_STATE_CONSUMED,
- touch_move_event_id);
- EXPECT_TRUE(TouchEventQueueEmpty());
- EXPECT_EQ(1U, ack_handler_->GetAndResetAckCount());
- EXPECT_EQ(WebInputEvent::TouchMove,
- ack_handler_->acked_touch_event().event.type());
- EXPECT_EQ(0U, GetSentMessageCountAndResetSink());
-}
-
-// Tests that touch-events are sent properly.
-TEST_F(InputRouterImplTest, TouchEventQueue) {
- OnHasTouchEventHandlers(true);
-
- PressTouchPoint(1, 1);
- uint32_t touch_press_event_id = SendTouchEvent();
- EXPECT_TRUE(client_->GetAndResetFilterEventCalled());
- EXPECT_EQ(1U, GetSentMessageCountAndResetSink());
- EXPECT_FALSE(TouchEventQueueEmpty());
-
- // The second touch should be sent right away.
- MoveTouchPoint(0, 5, 5);
- uint32_t touch_move_event_id = SendTouchEvent();
- EXPECT_TRUE(client_->GetAndResetFilterEventCalled());
- EXPECT_EQ(1U, GetSentMessageCountAndResetSink());
- EXPECT_FALSE(TouchEventQueueEmpty());
-
- // Receive an ACK for the first touch-event.
- SendTouchEventACK(WebInputEvent::TouchStart, INPUT_EVENT_ACK_STATE_CONSUMED,
- touch_press_event_id);
- EXPECT_FALSE(TouchEventQueueEmpty());
- EXPECT_EQ(1U, ack_handler_->GetAndResetAckCount());
- EXPECT_EQ(WebInputEvent::TouchStart,
- ack_handler_->acked_touch_event().event.type());
- EXPECT_EQ(0U, GetSentMessageCountAndResetSink());
SendTouchEventACK(WebInputEvent::TouchMove, INPUT_EVENT_ACK_STATE_CONSUMED,
touch_move_event_id);
@@ -1090,10 +1055,7 @@
WebInputEvent::Type type = eventTypes[i];
if (WebInputEventTraits::ShouldBlockEventStream(GetEventWithType(type))) {
SimulateGestureEvent(type, blink::WebGestureDeviceTouchscreen);
- if (type == WebInputEvent::GestureScrollUpdate)
- EXPECT_EQ(2U, GetSentMessageCountAndResetSink());
- else
- EXPECT_EQ(1U, GetSentMessageCountAndResetSink());
+ EXPECT_EQ(1U, GetSentMessageCountAndResetSink());
EXPECT_EQ(0U, ack_handler_->GetAndResetAckCount());
EXPECT_EQ(1, client_->in_flight_event_count());
EXPECT_TRUE(HasPendingEvents());
@@ -1179,7 +1141,7 @@
SimulateGestureEvent(WebInputEvent::GestureScrollUpdate,
blink::WebGestureDeviceTouchscreen);
- ASSERT_EQ(2U, GetSentMessageCountAndResetSink());
+ ASSERT_EQ(1U, GetSentMessageCountAndResetSink());
EXPECT_EQ(0U, ack_handler_->GetAndResetAckCount());
EXPECT_EQ(1, client_->in_flight_event_count());
@@ -1431,7 +1393,7 @@
// Ensure touch action is still none, as the next touch start hasn't been
// acked yet. ScrollBegin and ScrollEnd don't require acks.
- EXPECT_EQ(6U, GetSentMessageCountAndResetSink());
+ EXPECT_EQ(3U, GetSentMessageCountAndResetSink());
SimulateGestureEvent(WebInputEvent::GestureScrollBegin,
blink::WebGestureDeviceTouchscreen);
EXPECT_EQ(0U, GetSentMessageCountAndResetSink());
@@ -1449,7 +1411,7 @@
touch_press_event_id2);
SendTouchEventACK(WebInputEvent::TouchMove, INPUT_EVENT_ACK_STATE_CONSUMED,
touch_move_event_id2);
- EXPECT_EQ(0U, GetSentMessageCountAndResetSink());
+ EXPECT_EQ(3U, GetSentMessageCountAndResetSink());
SimulateGestureEvent(WebInputEvent::GestureScrollBegin,
blink::WebGestureDeviceTouchscreen);
EXPECT_EQ(1U, GetSentMessageCountAndResetSink());
@@ -1489,7 +1451,7 @@
// Ensure we have touch-action:none. ScrollBegin and ScrollEnd don't require
// acks.
- EXPECT_EQ(6U, GetSentMessageCountAndResetSink());
+ EXPECT_EQ(3U, GetSentMessageCountAndResetSink());
SimulateGestureEvent(WebInputEvent::GestureScrollBegin,
blink::WebGestureDeviceTouchscreen);
EXPECT_EQ(0U, GetSentMessageCountAndResetSink());
@@ -1504,7 +1466,7 @@
touch_press_event_id2);
// Ensure touch action has been set to auto, as the touch had no consumer.
- EXPECT_EQ(0U, GetSentMessageCountAndResetSink());
+ EXPECT_EQ(1U, GetSentMessageCountAndResetSink());
SimulateGestureEvent(WebInputEvent::GestureScrollBegin,
blink::WebGestureDeviceTouchscreen);
EXPECT_EQ(1U, GetSentMessageCountAndResetSink());
@@ -1525,15 +1487,15 @@
OnSetTouchAction(TOUCH_ACTION_NONE);
ReleaseTouchPoint(0);
uint32_t touch_release_event_id = SendTouchEvent();
- EXPECT_EQ(3U, GetSentMessageCountAndResetSink());
+ EXPECT_EQ(1U, GetSentMessageCountAndResetSink());
// Ensure we have touch-action:none, suppressing scroll events.
SendTouchEventACK(WebInputEvent::TouchStart, INPUT_EVENT_ACK_STATE_CONSUMED,
touch_press_event_id);
- EXPECT_EQ(0U, GetSentMessageCountAndResetSink());
+ EXPECT_EQ(1U, GetSentMessageCountAndResetSink());
SendTouchEventACK(WebInputEvent::TouchMove,
INPUT_EVENT_ACK_STATE_NOT_CONSUMED, touch_move_event_id);
- EXPECT_EQ(0U, GetSentMessageCountAndResetSink());
+ EXPECT_EQ(1U, GetSentMessageCountAndResetSink());
SimulateGestureEvent(WebInputEvent::GestureScrollBegin,
blink::WebGestureDeviceTouchscreen);
EXPECT_EQ(0U, GetSentMessageCountAndResetSink());
@@ -1560,7 +1522,8 @@
// Test that the double tap gesture depends on the touch action of the first
// tap.
-TEST_F(InputRouterImplTest, DoubleTapGestureDependsOnFirstTap) {
+TEST_F(InputRouterImplRafAlignedTouchEnabledTest,
+ DoubleTapGestureDependsOnFirstTap) {
OnHasTouchEventHandlers(true);
// Sequence 1.
@@ -1627,8 +1590,7 @@
// Test that the double tap gesture depends on the touch action of the first
// tap.
-TEST_F(InputRouterImplRafAlignedTouchDisabledTest,
- DoubleTapGestureDependsOnFirstTap) {
+TEST_F(InputRouterImplTest, DoubleTapGestureDependsOnFirstTap) {
OnHasTouchEventHandlers(true);
// Sequence 1.
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698