Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2725133005: Add 10.12 as a supported version in MacPort. (Closed)

Created:
3 years, 9 months ago by qyearsley
Modified:
3 years, 9 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, chromium-reviews, Dirk Pranke, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add 10.12 as a supported version in MacPort. In this CL: - Add a version mac10.12, with baseline path mac/ (mac10.11 should fall back to this path when there are no baselines in platform/mac10.11/, which there currently should never be. - Change PlatformInfo to add 10.12 - Also change PlatformInfo to raise an AssertionError for versions < 10.9 - Update tests. BUG=697971 Review-Url: https://codereview.chromium.org/2725133005 Cr-Commit-Position: refs/heads/master@{#454777} Committed: https://chromium.googlesource.com/chromium/src/+/2db55a16ab3ef68261da87bbafc2b849502e22e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -16 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info.py View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info_unittest.py View 4 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mac.py View 3 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
qyearsley
3 years, 9 months ago (2017-03-03 22:14:01 UTC) #5
jeffcarp
lgtm
3 years, 9 months ago (2017-03-03 23:34:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2725133005/1
3 years, 9 months ago (2017-03-04 18:46:43 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-04 18:53:10 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2db55a16ab3ef68261da87bbafc2...

Powered by Google App Engine
This is Rietveld 408576698