third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info.py - Issue 2725133005: Add 10.12 as a supported version in MacPort.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info.py

Issue 2725133005: Add 10.12 as a supported version in MacPort. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info.py

index 860fcd6a255eb623eb7e60675e7cc68fcb72fa69..acf588ac6334a98e2c19152457f455d499a9cb95 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info.py

@@ -147,9 +147,8 @@ class PlatformInfo(object):

def _determine_mac_version(self, mac_version_string):

minor_release = int(mac_version_string.split('.')[1])

- # FIXME: This should really be >= 9, and we should get rid of 'future'.

- assert minor_release >= 6, 'Unsupported mac os version: %s' % mac_version_string

- if minor_release in (9, 10, 11):

+ assert minor_release >= 9, 'Unsupported mac OS version: %s' % mac_version_string

+ if minor_release <= 12:

return 'mac10.%d' % minor_release

return 'future'

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info_unittest.py » ('j') | no next file with comments »