Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info_unittest.py

Issue 2725133005: Add 10.12 as a supported version in MacPort. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info_unittest.py
index eda5bc745f1872638a86a4e946ff60dfe3184a02..ff36290b2af86562b40672ef34add0e845892fdd 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info_unittest.py
@@ -47,7 +47,7 @@ def fake_sys(platform_str='darwin', windows_version_tuple=None):
return FakeSysModule()
-def fake_platform(mac_version_string='10.6.3', release_string='bar', linux_version='trusty'):
+def fake_platform(mac_version_string='10.12.3', release_string='bar', linux_version='trusty'):
class FakePlatformModule(object):
@@ -108,7 +108,7 @@ class TestPlatformInfo(unittest.TestCase):
self.assertFalse(info.is_win())
self.assertFalse(info.is_freebsd())
- info = self.make_info(fake_sys('darwin'), fake_platform('10.6.3'))
+ info = self.make_info(fake_sys('darwin'), fake_platform('10.12.3'))
self.assertEqual(info.os_name, 'mac')
self.assertFalse(info.is_linux())
self.assertTrue(info.is_mac())
@@ -139,11 +139,12 @@ class TestPlatformInfo(unittest.TestCase):
self.assertRaises(AssertionError, self.make_info, fake_sys('vms'))
def test_os_version(self):
- self.assertRaises(AssertionError, self.make_info, fake_sys('darwin'), fake_platform('10.4.3'))
+ self.assertRaises(AssertionError, self.make_info, fake_sys('darwin'), fake_platform('10.6.3'))
self.assertEqual(self.make_info(fake_sys('darwin'), fake_platform('10.9.0')).os_version, 'mac10.9')
self.assertEqual(self.make_info(fake_sys('darwin'), fake_platform('10.10.0')).os_version, 'mac10.10')
self.assertEqual(self.make_info(fake_sys('darwin'), fake_platform('10.11.0')).os_version, 'mac10.11')
- self.assertEqual(self.make_info(fake_sys('darwin'), fake_platform('10.12.0')).os_version, 'future')
+ self.assertEqual(self.make_info(fake_sys('darwin'), fake_platform('10.12.0')).os_version, 'mac10.12')
+ self.assertEqual(self.make_info(fake_sys('darwin'), fake_platform('10.15.0')).os_version, 'future')
self.assertEqual(self.make_info(fake_sys('linux2')).os_version, 'trusty')
info = self.make_info(fake_sys('linux2'), fake_platform(linux_version='utopic'))
@@ -203,7 +204,7 @@ class TestPlatformInfo(unittest.TestCase):
self.assertNotEquals(info.display_name(), '')
def test_total_bytes_memory(self):
- info = self.make_info(fake_sys('darwin'), fake_platform('10.6.3'), executive=fake_executive('1234'))
+ info = self.make_info(fake_sys('darwin'), fake_platform('10.12.3'), executive=fake_executive('1234'))
self.assertEqual(info.total_bytes_memory(), 1234)
info = self.make_info(fake_sys('win32', tuple([6, 1, 7600])))

Powered by Google App Engine
This is Rietveld 408576698