Test actual arguments in WebStateImplTest::ObserverTest.

Test actual arguments in WebStateImplTest::ObserverTest.

Also added tests for all Observer methods.

BUG=None

Review-Url: https://codereview.chromium.org/2724953004
Cr-Commit-Position: refs/heads/master@{#454462}
Committed: https://chromium.googlesource.com/chromium/src/+/e7305717cc00669fc2d4f8a718032f7c0023f9cf

[Eugene But (OOO till 7-30), 2017-03-02 03:56:43]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 03:57:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 04:07:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 04:07:10]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Eugene But (OOO till 7-30), 2017-03-02 15:54:12]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 15:54:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eugene But (OOO till 7-30), 2017-03-02 16:30:02]

eugenebut@chromium.org changed reviewers:
+ kkhorimoto@chromium.org

[commit-bot: I haz the power, 2017-03-02 17:11:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 17:11:26]

Dry run: This issue passed the CQ dry run.

[kkhorimoto, 2017-03-02 20:50:40]

https://codereview.chromium.org/2724953004/diff/20001/ios/web/public/test/fak...
File ios/web/public/test/fakes/test_web_state_observer_util.mm (right):

https://codereview.chromium.org/2724953004/diff/20001/ios/web/public/test/fak...
ios/web/public/test/fakes/test_web_state_observer_util.mm:10:
TestDidFinishNavigationInfo::TestDidFinishNavigationInfo() {}
Why are these in the .mm file?  Aren't they both the default implementations
supplied by the compiler?  It looks like TestFormActivityInfo and
TestUpdateFaviconUrlCandidatesInfo also include constructors/destructors in
their struct devinitions; why is TestDidFinishNavigationInfo treated
differently?

[Eugene But (OOO till 7-30), 2017-03-02 23:08:48]

https://codereview.chromium.org/2724953004/diff/20001/ios/web/public/test/fak...
File ios/web/public/test/fakes/test_web_state_observer_util.mm (right):

https://codereview.chromium.org/2724953004/diff/20001/ios/web/public/test/fak...
ios/web/public/test/fakes/test_web_state_observer_util.mm:10:
TestDidFinishNavigationInfo::TestDidFinishNavigationInfo() {}
On 2017/03/02 20:50:40, kkhorimoto_ wrote:
> Why are these in the .mm file?  Aren't they both the default implementations
> supplied by the compiler?  It looks like TestFormActivityInfo and
> TestUpdateFaviconUrlCandidatesInfo also include constructors/destructors in
> their struct devinitions; why is TestDidFinishNavigationInfo treated
> differently?
TestDidFinishNavigationInfo has a member with non-trivial default constructor.
Without this code compiler is not happy:

../../ios/web/public/test/fakes/test_web_state_observer_util.h:26:1: error:
[chromium-style] Complex class/struct needs an explicit out-of-line constructor.

[kkhorimoto, 2017-03-03 00:25:50]

lgtm

[Eugene But (OOO till 7-30), 2017-03-03 01:48:21]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-03-03 01:48:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 01:53:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488505701142290,
"parent_rev": "99ed48423a76851451298d54a5260cc30503fa1d", "commit_rev":
"e7305717cc00669fc2d4f8a718032f7c0023f9cf"}

[commit-bot: I haz the power, 2017-03-03 01:54:21]

Description was changed from

==========
Test actual arguments in WebStateImplTest::ObserverTest.

Also added tests for all Observer methods.

BUG=None
==========

to

==========
Test actual arguments in WebStateImplTest::ObserverTest.

Also added tests for all Observer methods.

BUG=None

Review-Url: https://codereview.chromium.org/2724953004
Cr-Commit-Position: refs/heads/master@{#454462}
Committed:
https://chromium.googlesource.com/chromium/src/+/e7305717cc00669fc2d4f8a71803...
==========

[commit-bot: I haz the power, 2017-03-03 01:54:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e7305717cc00669fc2d4f8a71803...