ios/web/public/test/fakes/test_web_state_observer_util.mm - Issue 2724953004: Test actual arguments in WebStateImplTest::ObserverTest.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/web/public/test/fakes/test_web_state_observer_util.mm

Issue 2724953004: Test actual arguments in WebStateImplTest::ObserverTest. (Closed)

Patch Set: Rebased Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #import "ios/web/public/test/fakes/test_web_state_observer_util.h"

	6

	7 #include "ios/web/public/web_state/navigation_context.h"

	8

	9 namespace web {

	10 TestDidFinishNavigationInfo::TestDidFinishNavigationInfo() {}
	kkhorimoto 2017/03/02 20:50:40 Why are these in the .mm file? Aren't they both t Why are these in the .mm file? Aren't they both the default implementations supplied by the compiler? It looks like TestFormActivityInfo and TestUpdateFaviconUrlCandidatesInfo also include constructors/destructors in their struct devinitions; why is TestDidFinishNavigationInfo treated differently? Eugene But (OOO till 7-30) 2017/03/02 23:08:48 TestDidFinishNavigationInfo has a member with non- Show quoted text On 2017/03/02 20:50:40, kkhorimoto_ wrote: > Why are these in the .mm file? Aren't they both the default implementations > supplied by the compiler? It looks like TestFormActivityInfo and > TestUpdateFaviconUrlCandidatesInfo also include constructors/destructors in > their struct devinitions; why is TestDidFinishNavigationInfo treated > differently? TestDidFinishNavigationInfo has a member with non-trivial default constructor. Without this code compiler is not happy: ../../ios/web/public/test/fakes/test_web_state_observer_util.h:26:1: error: [chromium-style] Complex class/struct needs an explicit out-of-line constructor.
	11 TestDidFinishNavigationInfo::~TestDidFinishNavigationInfo() = default;

	12 } // namespace web

OLD	NEW

« no previous file with comments | « ios/web/public/test/fakes/test_web_state_observer_util.h ('k') | ios/web/web_state/web_state_impl_unittest.mm » ('j') | no next file with comments »