Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: ios/web/public/test/fakes/crw_test_web_state_observer.h

Issue 2724953004: Test actual arguments in WebStateImplTest::ObserverTest. (Closed)
Patch Set: Rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/public/test/fakes/crw_test_web_state_observer.h
diff --git a/ios/web/public/test/fakes/crw_test_web_state_observer.h b/ios/web/public/test/fakes/crw_test_web_state_observer.h
index 3e2e8527b3b892bb8bea32d4abe31e088c4938b9..d94644d28664aedf6c4bf18fbb0940a34587247c 100644
--- a/ios/web/public/test/fakes/crw_test_web_state_observer.h
+++ b/ios/web/public/test/fakes/crw_test_web_state_observer.h
@@ -5,110 +5,9 @@
#ifndef IOS_WEB_PUBLIC_TEST_FAKES_CRW_TEST_WEB_STATE_OBSERVER_H_
#define IOS_WEB_PUBLIC_TEST_FAKES_CRW_TEST_WEB_STATE_OBSERVER_H_
-#include "ios/web/public/favicon_url.h"
-#include "ios/web/public/load_committed_details.h"
+#include "ios/web/public/test/fakes/test_web_state_observer_util.h"
#import "ios/web/public/web_state/web_state_observer_bridge.h"
-namespace web {
-
-class NavigationContext;
-class WebState;
-
-// Arguments passed to |webState:didStartProvisionalNavigationForURL:|.
-struct TestStartProvisionalNavigationInfo {
- WebState* web_state;
- GURL url;
-};
-
-// Arguments passed to |webState:didFinishNavigation:|.
-struct TestDidFinishNavigationInfo {
- WebState* web_state;
- web::NavigationContext* context;
-};
-
-// Arguments passed to |webState:didCommitNavigationWithDetails:|.
-struct TestCommitNavigationInfo {
- WebState* web_state;
- LoadCommittedDetails load_details;
-};
-
-// Arguments passed to |webState:didLoadPageWithSuccess:|.
-struct TestLoadPageInfo {
- WebState* web_state;
- BOOL success;
-};
-
-// Arguments passed to |webStateDidDismissInterstitial:|.
-struct TestDismissInterstitialInfo {
- WebState* web_state;
-};
-
-// Arguments passed to |webStateDidChangeHistoryState:|.
-struct TestChangeHistoryStateInfo {
- WebState* web_state;
-};
-
-// Arguments passed to |webState:didChangeLoadingProgress:|.
-struct TestChangeLoadingProgressInfo {
- WebState* web_state;
- double progress;
-};
-
-// Arguments passed to |webStateDidChangeTitle:|.
-struct TestTitleWasSetInfo {
- WebState* web_state;
-};
-
-// Arguments passed to |webState:didSubmitDocumentWithFormNamed:userInitiated:|.
-struct TestSubmitDocumentInfo {
- WebState* web_state;
- std::string form_name;
- BOOL user_initiated;
-};
-
-// Arguments passed to
-// |webState:didRegisterFormActivityWithFormNamed:fieldName:type:value:|.
-struct TestFormActivityInfo {
- TestFormActivityInfo();
- ~TestFormActivityInfo();
- WebState* web_state;
- std::string form_name;
- std::string field_name;
- std::string type;
- std::string value;
- bool input_missing;
-};
-
-// Arguments passed to |webState:didUpdateFaviconURLCandidates|.
-struct TestUpdateFaviconUrlCandidatesInfo {
- TestUpdateFaviconUrlCandidatesInfo();
- ~TestUpdateFaviconUrlCandidatesInfo();
- WebState* web_state;
- std::vector<web::FaviconURL> candidates;
-};
-
-// Arguments passed to |webState:renderProcessGoneForWebState:|.
-struct TestRenderProcessGoneInfo {
- WebState* web_state;
-};
-
-// Arguments passed to |webStateDestroyed:|.
-struct TestWebStateDestroyedInfo {
- WebState* web_state;
-};
-
-// Arguments passed to |webStateDidStopLoading:|.
-struct TestStopLoadingInfo {
- WebState* web_state;
-};
-
-// Arguments passed to |webStateDidStartLoading:|.
-struct TestStartLoadingInfo {
- WebState* web_state;
-};
-
-} // namespace web
-
// Test implementation of CRWWebStateObserver protocol.
@interface CRWTestWebStateObserver : NSObject<CRWWebStateObserver>
@@ -126,9 +25,6 @@ struct TestStartLoadingInfo {
// Arguments passed to |webStateDidDismissInterstitial:|.
@property(nonatomic, readonly)
web::TestDismissInterstitialInfo* dismissInterstitialInfo;
-// Arguments passed to |webStateDidChangeHistoryState:|.
-@property(nonatomic, readonly)
- web::TestChangeHistoryStateInfo* changeHistoryStateInfo;
// Arguments passed to |webState:didChangeLoadingProgress:|.
@property(nonatomic, readonly)
web::TestChangeLoadingProgressInfo* changeLoadingProgressInfo;

Powered by Google App Engine
This is Rietveld 408576698