Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2720973002: Switch RemoteWindowProxy to use v8::Context::NewRemoteContext. (Closed)

Created:
3 years, 9 months ago by dcheng
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, extensions-reviews_chromium.org, mlamouri+watch-blink_chromium.org, dcheng, blink-reviews-api_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, blink-reviews-frames_chromium.org, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch RemoteWindowProxy to use v8::Context::NewRemoteContext. BUG=527190 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Rebase after split #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -122 lines) Patch
M components/guest_view/renderer/guest_view_request.cc View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h View 1 2 3 chunks +0 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp View 1 2 5 chunks +15 lines, -71 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.h View 1 2 3 chunks +23 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.h View 1 3 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteFrame.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.h View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/public/web/WebRemoteFrame.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (12 generated)
dcheng
The CQ bit was checked by dcheng@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-02-28 05:37:58 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720973002/20001
3 years, 9 months ago (2017-02-28 05:38:24 UTC) #2
dcheng
Description was changed from ========== Switch RemoteWindowProxy to use v8::Context::NewRemoteContext. BUG=527190 ========== to ========== Switch ...
3 years, 9 months ago (2017-02-28 06:47:49 UTC) #3
dcheng
The CQ bit was unchecked by dcheng@chromium.org
3 years, 9 months ago (2017-02-28 06:47:54 UTC) #4
dcheng
The CQ bit was checked by dcheng@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-02-28 06:47:59 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720973002/20001
3 years, 9 months ago (2017-02-28 06:48:02 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-02-28 07:27:41 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 9 months ago (2017-02-28 07:27:42 UTC) #8
dcheng
The CQ bit was checked by dcheng@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-01 06:05:11 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720973002/40001
3 years, 9 months ago (2017-03-01 06:05:25 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-01 08:05:05 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 08:05:06 UTC) #12 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698