Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h

Issue 2724573002: Prepare WindowProxy for using v8::Context::NewRemoteContext(). (Closed)
Patch Set: Remove duplicate v8 include Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 14 matching lines...) Expand all
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef RemoteWindowProxy_h 31 #ifndef RemoteWindowProxy_h
32 #define RemoteWindowProxy_h 32 #define RemoteWindowProxy_h
33 33
34 #include "bindings/core/v8/DOMWrapperWorld.h" 34 #include "bindings/core/v8/DOMWrapperWorld.h"
35 #include "bindings/core/v8/ScriptState.h"
36 #include "bindings/core/v8/WindowProxy.h"
35 #include "core/frame/RemoteFrame.h" 37 #include "core/frame/RemoteFrame.h"
36 #include "v8/include/v8.h" 38 #include "v8/include/v8.h"
39 #include "wtf/RefPtr.h"
37 40
38 namespace blink { 41 namespace blink {
39 42
40 // Subclass of WindowProxy that only handles RemoteFrame. 43 // Subclass of WindowProxy that only handles RemoteFrame.
44 // TODO(dcheng): This class currently duplicates a lot of logic from
45 // LocalWindowPoxy:
46 // - contextIfInitialized
47 // - initialize
48 // - disposeContext
49 // - setupWindowPrototypeChain
50 // - createContext
51 // This is currently duplicated to make it easier to stage the switch to using
52 // v8::RemoteContext::NewRemoteContext, and will be removed once the switch
53 // is complete.
41 class RemoteWindowProxy final : public WindowProxy { 54 class RemoteWindowProxy final : public WindowProxy {
42 public: 55 public:
43 static RemoteWindowProxy* create(v8::Isolate* isolate, 56 static RemoteWindowProxy* create(v8::Isolate* isolate,
44 RemoteFrame& frame, 57 RemoteFrame& frame,
45 58
46 RefPtr<DOMWrapperWorld> world) { 59 RefPtr<DOMWrapperWorld> world) {
47 return new RemoteWindowProxy(isolate, frame, std::move(world)); 60 return new RemoteWindowProxy(isolate, frame, std::move(world));
48 } 61 }
49 62
63 v8::Local<v8::Context> contextIfInitialized() const {
64 return m_scriptState ? m_scriptState->context() : v8::Local<v8::Context>();
65 }
66
50 private: 67 private:
51 RemoteWindowProxy(v8::Isolate*, RemoteFrame&, RefPtr<DOMWrapperWorld>); 68 RemoteWindowProxy(v8::Isolate*, RemoteFrame&, RefPtr<DOMWrapperWorld>);
52 69
53 void initialize() override; 70 void initialize() override;
54 void disposeContext(GlobalDetachmentBehavior) override; 71 void disposeContext(GlobalDetachmentBehavior) override;
55 72
73 // Associates the window wrapper and its prototype chain with the native
74 // DOMWindow object. Also does some more Window-specific initialization.
75 void setupWindowPrototypeChain();
76
56 // Creates a new v8::Context with the window wrapper object as the global 77 // Creates a new v8::Context with the window wrapper object as the global
57 // object (aka the inner global). Note that the window wrapper and its 78 // object (aka the inner global). Note that the window wrapper and its
58 // prototype chain do not get fully initialized yet, e.g. the window 79 // prototype chain do not get fully initialized yet, e.g. the window
59 // wrapper is not yet associated with the native DOMWindow object. 80 // wrapper is not yet associated with the native DOMWindow object.
60 void createContext(); 81 void createContext();
82
83 RefPtr<ScriptState> m_scriptState;
61 }; 84 };
62 85
63 } // namespace blink 86 } // namespace blink
64 87
65 #endif // RemoteWindowProxy_h 88 #endif // RemoteWindowProxy_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698