Renamed deviceScaleFactor() to deviceScaleFactorDeprecated() in Page

Renamed deviceScaleFactor() to deviceScaleFactorDeprecated() in Page

Renamed the deviceScaleFactor() method to deviceScaleFactorDeprecated()
in the Page class, to be consistent with the FrameHost method that calls
this one. Also moved the comment for the method to the Page class.

This is pre-work to remove FrameHost::deviceScaleFactorDeprecated(), and
is part of merging FrameHost back into Page.

BUG=691794
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2724543002
Cr-Commit-Position: refs/heads/master@{#453871}
Committed: https://chromium.googlesource.com/chromium/src/+/0c23baccef3a9647076ad0dde83a1a847c702b03

[sashab, 2017-02-28 04:20:37]

Description was changed from

==========
Renamed deviceScaleFactor() to deviceScaleFactorDeprecated() in Page

Renamed the deviceScaleFactor() method to deviceScaleFactorDeprecated()
in the Page class, to be consistent with the FrameHost method that calls
this one. Also moved the comment for the method to the Page class.

This is pre-work to remove FrameHost::deviceScaleFactorDeprecated(), and
is part of merging FrameHost back into Page.

BUG=691794
==========

to

==========
Renamed deviceScaleFactor() to deviceScaleFactorDeprecated() in Page

Renamed the deviceScaleFactor() method to deviceScaleFactorDeprecated()
in the Page class, to be consistent with the FrameHost method that calls
this one. Also moved the comment for the method to the Page class.

This is pre-work to remove FrameHost::deviceScaleFactorDeprecated(), and
is part of merging FrameHost back into Page.

BUG=691794
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[sashab, 2017-02-28 04:20:40]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 04:21:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2017-02-28 04:21:31]

sashab@chromium.org changed reviewers:
+ slangley@chromium.org

[sashab, 2017-02-28 04:21:32]

https://codereview.chromium.org/2724543002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/FrameHost.h (left):

https://codereview.chromium.org/2724543002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/FrameHost.h:44: class ChromeClient;
This is funny... This only broke a presubmit check because it's no longer used
in the comment below... Oh dear :P

[haraken, 2017-02-28 04:25:07]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2017-02-28 04:25:08]

LGTM

https://codereview.chromium.org/2724543002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/FrameHost.h (right):

https://codereview.chromium.org/2724543002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/FrameHost.h:75: float
deviceScaleFactorDeprecated() const;

Why can't we remove this?

[sashab, 2017-02-28 04:26:17]

https://codereview.chromium.org/2724543002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/FrameHost.h (right):

https://codereview.chromium.org/2724543002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/FrameHost.h:75: float
deviceScaleFactorDeprecated() const;
On 2017/02/28 at 04:25:08, haraken wrote:
> Why can't we remove this?

Doing it in a follow-up patch, to keep the rename change separate. :)

[commit-bot: I haz the power, 2017-02-28 07:00:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 07:00:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sashab, 2017-02-28 23:13:46]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2017-02-28 23:15:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2017-02-28 23:27:16]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 23:27:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 00:51:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 00:51:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sashab, 2017-03-01 05:37:13]

The CQ bit was checked by sashab@chromium.org

[sashab, 2017-03-01 05:37:13]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2724543002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-01 05:37:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 06:54:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488346633486610,
"parent_rev": "e5a6eef5a42368c79fe80beac730e53e544736df", "commit_rev":
"0c23baccef3a9647076ad0dde83a1a847c702b03"}

[commit-bot: I haz the power, 2017-03-01 06:56:02]

Description was changed from

==========
Renamed deviceScaleFactor() to deviceScaleFactorDeprecated() in Page

Renamed the deviceScaleFactor() method to deviceScaleFactorDeprecated()
in the Page class, to be consistent with the FrameHost method that calls
this one. Also moved the comment for the method to the Page class.

This is pre-work to remove FrameHost::deviceScaleFactorDeprecated(), and
is part of merging FrameHost back into Page.

BUG=691794
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Renamed deviceScaleFactor() to deviceScaleFactorDeprecated() in Page

Renamed the deviceScaleFactor() method to deviceScaleFactorDeprecated()
in the Page class, to be consistent with the FrameHost method that calls
this one. Also moved the comment for the method to the Page class.

This is pre-work to remove FrameHost::deviceScaleFactorDeprecated(), and
is part of merging FrameHost back into Page.

BUG=691794
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2724543002
Cr-Commit-Position: refs/heads/master@{#453871}
Committed:
https://chromium.googlesource.com/chromium/src/+/0c23baccef3a9647076ad0dde83a...
==========

[commit-bot: I haz the power, 2017-03-01 06:56:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0c23baccef3a9647076ad0dde83a...