Renamed deviceScaleFactor() to deviceScaleFactorDeprecated() in Page

third_party/WebKit/Source/core/frame/FrameHost.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 23 matching lines @@
 #include "core/CoreExport.h"
 #include "platform/heap/Handle.h"
 #include "wtf/Allocator.h"
 #include "wtf/Noncopyable.h"
 #include "wtf/text/AtomicString.h"
 #include <memory>
 
 namespace blink {
 
 class BrowserControls;
-class ChromeClient;

[sashab, 2017/02/28 04:21:32]

This is funny... This only broke a presubmit check because it's no longer used
in the comment below... Oh dear :P

 class ConsoleMessageStorage;
 class EventHandlerRegistry;
 class OverscrollController;
 class Page;
 struct PageScaleConstraints;
 class PageScaleConstraintsSet;
 class TopDocumentRootScrollerController;
 class VisualViewport;
 
 // FrameHost is the set of global data shared between multiple frames
@@ skipping 10 matching lines @@
     : public GarbageCollectedFinalized<FrameHost> {
   WTF_MAKE_NONCOPYABLE(FrameHost);
 
  public:
   static FrameHost* create(Page&);
   ~FrameHost();
 
   Page& page();
   const Page& page() const;
 
-  // Corresponds to pixel density of the device where this Page is
-  // being displayed. In multi-monitor setups this can vary between pages.
-  // This value does not account for Page zoom, use LocalFrame::devicePixelRatio
-  // instead.  This is to be deprecated. Use this with caution.
-  // 1) If you need to scale the content per device scale factor, this is still
-  //    valid.  In use-zoom-for-dsf mode, this is always 1, and will be remove
-  //    when transition is complete.
-  // 2) If you want to compute the device related measure (such as device pixel
-  //    height, or the scale factor for drag image), use
-  //    ChromeClient::screenInfo() instead.
+  // See Page::deviceScaleFactorDeprecated.
   float deviceScaleFactorDeprecated() const;

[haraken, 2017/02/28 04:25:08]

Why can't we remove this?

[sashab, 2017/02/28 04:26:16]

Doing it in a follow-up patch, to keep the rename change separate. :)

 
   BrowserControls& browserControls();
   const BrowserControls& browserControls() const;
 
   OverscrollController& overscrollController();
   const OverscrollController& overscrollController() const;
 
   VisualViewport& visualViewport();
   const VisualViewport& visualViewport() const;
 
@@ skipping 39 matching lines @@
   const Member<TopDocumentRootScrollerController>
       m_globalRootScrollerController;
 
   AtomicString m_overrideEncoding;
   int m_subframeCount;
 };
 
 }  // namespace blink
 
 #endif  // FrameHost_h