Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 2719293002: Removed FrameHost::deviceScaleFactorDeprecated() (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews, dcheng, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed FrameHost::deviceScaleFactorDeprecated() Removed the FrameHost::deviceScaleFactorDeprecated() method, and redirected calls to Page::deviceScaleFactorDeprecated() using FrameHost's Page reference (or directly on the Page object if it is available). Also removed now-redundant FrameHost.h includes. This is part of the work to merge FrameHost back into Page. BUG=691794 Review-Url: https://codereview.chromium.org/2719293002 Cr-Commit-Position: refs/heads/master@{#454165} Committed: https://chromium.googlesource.com/chromium/src/+/9bcb0bd7cd927a70d47c983fbd071ccf6cdded58

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -14 lines) Patch
M third_party/WebKit/Source/core/frame/FrameHost.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/DragController.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (13 generated)
sashab
3 years, 9 months ago (2017-02-28 04:28:04 UTC) #3
haraken
LGTM
3 years, 9 months ago (2017-02-28 04:29:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719293002/20001
3 years, 9 months ago (2017-03-01 22:53:29 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 03:39:05 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9bcb0bd7cd927a70d47c983fbd07...

Powered by Google App Engine
This is Rietveld 408576698