Deduplicating code |WebContentsDelegateAndroid::ShowContextMenu()|

Deduplicating code |WebContentsDelegateAndroid::ShowContextMenu()|

Clank, webview, and content shell had duplicate code for showing the
paste popup menu in |ShowContextMenu()|. This CL de-duped it.

BUG=627234
Review-Url: https://codereview.chromium.org/2724533002
Cr-Commit-Position: refs/heads/master@{#453810}
Committed: https://chromium.googlesource.com/chromium/src/+/06806262e39e0adb4ab6744df62c33c4abedf8c8

[amaralp, 2017-02-28 03:42:09]

The CQ bit was checked by amaralp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 03:42:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[amaralp, 2017-02-28 03:43:20]

amaralp@chromium.org changed reviewers:
+ aelias@chromium.org

[amaralp, 2017-02-28 03:43:25]

PTAL

[commit-bot: I haz the power, 2017-02-28 04:05:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 04:05:42]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[amaralp, 2017-02-28 04:09:02]

The CQ bit was checked by amaralp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 04:09:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 04:38:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 04:38:55]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[amaralp, 2017-02-28 05:22:06]

The CQ bit was checked by amaralp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 05:22:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 06:04:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 06:04:27]

Dry run: This issue passed the CQ dry run.

[aelias_OOO_until_Jul13, 2017-02-28 21:33:59]

lgtm

[amaralp, 2017-02-28 21:39:58]

amaralp@chromium.org changed reviewers:
+ boliu@chromium.org, tedchoc@chromium.org

[amaralp, 2017-02-28 21:40:31]

Adding boliu@ and tedchoc@ for OWNERS

[boliu, 2017-02-28 22:10:48]

lgtm % comments

https://codereview.chromium.org/2724533002/diff/40001/content/browser/android...
File content/browser/android/content_view_core_impl.h (right):

https://codereview.chromium.org/2724533002/diff/40001/content/browser/android...
content/browser/android/content_view_core_impl.h:25: #include
"content/public/common/context_menu_params.h"
forward declare should be enough

https://codereview.chromium.org/2724533002/diff/40001/content/public/browser/...
File content/public/browser/android/content_view_core.h (right):

https://codereview.chromium.org/2724533002/diff/40001/content/public/browser/...
content/public/browser/android/content_view_core.h:15: #include
"content/public/common/context_menu_params.h"
ditto

[Ted C, 2017-02-28 22:25:39]

lgtm

[amaralp, 2017-02-28 23:22:31]

The CQ bit was checked by amaralp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 23:23:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 23:49:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 23:49:12]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[amaralp, 2017-03-01 02:12:19]

The CQ bit was checked by amaralp@chromium.org

[amaralp, 2017-03-01 02:12:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, aelias@chromium.org, boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2724533002/#ps80001
(title: "ContextMenuParams is a struct")

[commit-bot: I haz the power, 2017-03-01 02:13:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 03:08:38]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488334339125780,
"parent_rev": "73f7033f99cd065bb7fb7531c8dc3cb2b115fd5e", "commit_rev":
"06806262e39e0adb4ab6744df62c33c4abedf8c8"}

[commit-bot: I haz the power, 2017-03-01 03:09:18]

Description was changed from

==========
Deduplicating code |WebContentsDelegateAndroid::ShowContextMenu()|

Clank, webview, and content shell had duplicate code for showing the
paste popup menu in |ShowContextMenu()|. This CL de-duped it.

BUG=627234
==========

to

==========
Deduplicating code |WebContentsDelegateAndroid::ShowContextMenu()|

Clank, webview, and content shell had duplicate code for showing the
paste popup menu in |ShowContextMenu()|. This CL de-duped it.

BUG=627234

Review-Url: https://codereview.chromium.org/2724533002
Cr-Commit-Position: refs/heads/master@{#453810}
Committed:
https://chromium.googlesource.com/chromium/src/+/06806262e39e0adb4ab6744df62c...
==========

[commit-bot: I haz the power, 2017-03-01 03:09:19]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/06806262e39e0adb4ab6744df62c...