Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7652)

Unified Diff: chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc

Issue 2724533002: Deduplicating code |WebContentsDelegateAndroid::ShowContextMenu()| (Closed)
Patch Set: ContextMenuParams is a struct Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc
diff --git a/chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc b/chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc
index 5d226806759ceee2097986856df8c6cfbdce591f..f7a56836ebbf21422cac332802caa36c266766a0 100644
--- a/chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc
+++ b/chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc
@@ -30,16 +30,10 @@ ChromeWebContentsViewDelegateAndroid::GetDragDestDelegate() {
void ChromeWebContentsViewDelegateAndroid::ShowContextMenu(
content::RenderFrameHost* render_frame_host,
const content::ContextMenuParams& params) {
- // Display paste pop-up only when selection is empty and editable.
- if (params.is_editable && params.selection_text.empty()) {
- content::ContentViewCore* content_view_core =
- content::ContentViewCore::FromWebContents(web_contents_);
- if (content_view_core) {
- content_view_core->ShowPastePopup(params.selection_start.x(),
- params.selection_start.y());
- }
+ content::ContentViewCore* content_view_core =
+ content::ContentViewCore::FromWebContents(web_contents_);
+ if (content_view_core && content_view_core->ShowPastePopup(params))
return;
- }
// TODO(dtrainor, kouhei): Give WebView a Populator/delegate so it can use
// the same context menu code.
« no previous file with comments | « android_webview/native/aw_web_contents_view_delegate.cc ('k') | content/browser/android/content_view_core_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698