content/public/browser/android/content_view_core.h - Issue 2724533002: Deduplicating code |WebContentsDelegateAndroid::ShowContextMenu()|

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/android/content_view_core.h

Issue 2724533002: Deduplicating code |WebContentsDelegateAndroid::ShowContextMenu()| (Closed)

Patch Set: ContextMenuParams is a struct Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/browser/android/content_view_core.h

diff --git a/content/public/browser/android/content_view_core.h b/content/public/browser/android/content_view_core.h

index 965ba3fc47cf5b0a0057fdfff392a43648159b64..2ef486123c74dc3768398db9b08b3d5d217f1908 100644

--- a/content/public/browser/android/content_view_core.h

+++ b/content/public/browser/android/content_view_core.h

@@ -22,6 +22,7 @@ class WindowAndroid;

namespace content {

class WebContents;

+struct ContextMenuParams;

// DEPRECATED. Do not add methods.

// Refer to the public WebContents interface or elsewhere instead.

@@ -34,7 +35,7 @@ class CONTENT_EXPORT ContentViewCore {

// May return null reference.

virtual base::android::ScopedJavaLocalRef<jobject> GetJavaObject() = 0;

- virtual void ShowPastePopup(int x, int y) = 0;

+ virtual bool ShowPastePopup(const ContextMenuParams& params) = 0;

virtual ui::WindowAndroid* GetWindowAndroid() const = 0;