Make generate_gradle.py work with preview SDKs.

build/android/gradle/generate_gradle.py

Index: build/android/gradle/generate_gradle.py
diff --git a/build/android/gradle/generate_gradle.py b/build/android/gradle/generate_gradle.py
index 2044aa375775905240472d0042bb002f3246c282..8cd33e651c1a8fe2f34822411c82c677167c5f18 100755
--- a/build/android/gradle/generate_gradle.py
+++ b/build/android/gradle/generate_gradle.py
@@ -92,9 +92,9 @@ def _WriteFile(path, data):
     output_file.write(data)
 
 
-def _ReadBuildVars(output_dir):
-  with open(os.path.join(output_dir, 'build_vars.txt')) as f:
-    return dict(l.rstrip().split('=', 1) for l in f)
+def _ReadPropertiesFile(path):
+  with open(path) as f:
+    return dict(l.rstrip().split('=', 1) for l in f if '=' in l)
 
 
 def _RunNinja(output_dir, args):
@@ -514,9 +514,11 @@ def _GenerateGradleFile(entry, generator, build_vars, jinja_processor):
   variables['template_type'] = target_type
   variables['use_gradle_process_resources'] = (
       generator.use_gradle_process_resources)
-  variables['build_tools_version'] = (
-      build_vars['android_sdk_build_tools_version'])
-  variables['compile_sdk_version'] = build_vars['android_sdk_version']
+  source_properties = _ReadPropertiesFile(
+      os.path.join(build_vars['android_sdk_build_tools'], 'source.properties'))

[nyquist, 2017/03/01 01:22:12]

In my local checkout, os.getcwd() ends up being src/ if I run the command from
src/, so now what used to work fails with:
Traceback (most recent call last):
  File "/...snip.../chromium/src/build/android/gradle/generate_gradle.py", line
747, in <module>
    main()
  File "/...snip.../chromium/src/build/android/gradle/generate_gradle.py", line
708, in main
    data = _GenerateGradleFile(entry, generator, build_vars, jinja_processor)
  File "/...snip...t/chromium/src/build/android/gradle/generate_gradle.py", line
520, in _GenerateGradleFile
    os.path.join(build_vars['android_sdk_build_tools'], 'source.properties'))
  File "/...snip.../chromium/src/build/android/gradle/generate_gradle.py", line
96, in _ReadPropertiesFile
    with open(path) as f:
IOError: [Errno 2] No such file or directory:
'../../third_party/android_tools/sdk/build-tools/24.0.2/source.properties'


But if I cd into my out/Default (or whatever build place), and re-run the
command, it works.

[agrieve, 2017/03/01 01:24:16]

Doh! Clearly wrong. I'll revert & reland.

+  variables['build_tools_version'] = source_properties['Pkg.Revision']
+  variables['compile_sdk_version'] = (
+      'android-%s' % build_vars['android_sdk_version'])
   variables['main'] = generator.Generate(entry)
   bootclasspath = gradle.get('bootclasspath')
   if bootclasspath:
@@ -660,7 +662,7 @@ def main():
   _gradle_output_dir = os.path.abspath(
       args.project_dir.replace('$CHROMIUM_OUTPUT_DIR', output_dir))
   jinja_processor = jinja_template.JinjaProcessor(_FILE_DIR)
-  build_vars = _ReadBuildVars(output_dir)
+  build_vars = _ReadPropertiesFile(os.path.join(output_dir, 'build_vars.txt'))
   generator = _ProjectContextGenerator(_gradle_output_dir, build_vars,
       args.use_gradle_process_resources, jinja_processor, args.split_projects)
   logging.warning('Creating project at: %s', generator.project_dir)