Chromium Code Reviews
DescriptionRemoved -[CRWWebDelegate webDidStartLoadingURL:updateHistory:].
This callback is replaced by WebStateObserver::DidFinishNavigation.
Call OnNavigationCommitted after |webPageChanged|, because
NavigationItem is committed inside |webPageChanged|.
UpdateHttpResponseHeaders() should still be called before
SetContentsMimeType(), so |UpdateHttpResponseHeaders| was moved
out of |OnNavigationCommitted|.
BUG=692331, 698410
Review-Url: https://codereview.chromium.org/2724383003
Cr-Commit-Position: refs/heads/master@{#455167}
Committed: https://chromium.googlesource.com/chromium/src/+/9b8867c5b4b08dd484fb631fadacb6d247cdc7cf
Patch Set 1 #Patch Set 2 : Call OnNavigationCommitted after |webPageChanged| #Patch Set 3 : Fixed tests #Patch Set 4 : Fixed tests #Patch Set 5 : Fixed unit tests #Patch Set 6 : Self review #Patch Set 7 : Fixed ios_web_unittests #
Messages
Total messages: 31 (26 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||