Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2724383003: Removed -[CRWWebDelegate webDidStartLoadingURL:updateHistory:]. (Closed)

Created:
3 years, 9 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 9 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, marq+watch_chromium.org, Eugene But (OOO till 7-30), pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed -[CRWWebDelegate webDidStartLoadingURL:updateHistory:]. This callback is replaced by WebStateObserver::DidFinishNavigation. Call OnNavigationCommitted after |webPageChanged|, because NavigationItem is committed inside |webPageChanged|. UpdateHttpResponseHeaders() should still be called before SetContentsMimeType(), so |UpdateHttpResponseHeaders| was moved out of |OnNavigationCommitted|. BUG=692331, 698410 Review-Url: https://codereview.chromium.org/2724383003 Cr-Commit-Position: refs/heads/master@{#455167} Committed: https://chromium.googlesource.com/chromium/src/+/9b8867c5b4b08dd484fb631fadacb6d247cdc7cf

Patch Set 1 #

Patch Set 2 : Call OnNavigationCommitted after |webPageChanged| #

Patch Set 3 : Fixed tests #

Patch Set 4 : Fixed tests #

Patch Set 5 : Fixed unit tests #

Patch Set 6 : Self review #

Patch Set 7 : Fixed ios_web_unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -38 lines) Patch
M ios/chrome/browser/tabs/tab.mm View 1 2 3 4 2 chunks +6 lines, -9 lines 0 comments Download
M ios/chrome/browser/tabs/tab_unittest.mm View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M ios/web/navigation/crw_session_controller.mm View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/public/web_state/ui/crw_web_delegate.h View 1 chunk +1 line, -8 lines 0 comments Download
M ios/web/web_state/navigation_callbacks_inttest.mm View 1 2 3 4 3 chunks +10 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 2 3 4 5 8 chunks +10 lines, -10 lines 0 comments Download
M ios/web/web_state/web_state_impl.h View 1 2 3 4 2 chunks +6 lines, -5 lines 0 comments Download
M ios/web/web_state/web_state_impl.mm View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/web_state/web_state_impl_unittest.mm View 1 2 3 4 5 6 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 31 (26 generated)
Eugene But (OOO till 7-30)
3 years, 9 months ago (2017-03-03 02:31:06 UTC) #8
Eugene But (OOO till 7-30)
Kurt?
3 years, 9 months ago (2017-03-07 17:08:25 UTC) #25
kkhorimoto
lgtm
3 years, 9 months ago (2017-03-07 18:43:08 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724383003/110001
3 years, 9 months ago (2017-03-07 18:47:33 UTC) #28
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 19:07:35 UTC) #31
Message was sent while issue was closed.
Committed patchset #7 (id:110001) as
https://chromium.googlesource.com/chromium/src/+/9b8867c5b4b08dd484fb631fadac...

Powered by Google App Engine
This is Rietveld 408576698