Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: ios/chrome/browser/tabs/tab_unittest.mm

Issue 2724383003: Removed -[CRWWebDelegate webDidStartLoadingURL:updateHistory:]. (Closed)
Patch Set: Fixed ios_web_unittests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab.mm ('k') | ios/web/navigation/crw_session_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab_unittest.mm
diff --git a/ios/chrome/browser/tabs/tab_unittest.mm b/ios/chrome/browser/tabs/tab_unittest.mm
index 4255a8c9f88de480e6a1746476fcc4f2970e1d5f..d2c4a403e3daffc99d34903d7643c18747c03384 100644
--- a/ios/chrome/browser/tabs/tab_unittest.mm
+++ b/ios/chrome/browser/tabs/tab_unittest.mm
@@ -239,8 +239,8 @@ class TabTest : public BlockCleanupTest {
web_state_impl_->OnProvisionalNavigationStarted(redirectUrl);
[[tab_ navigationManagerImpl]->GetSessionController() commitPendingItem];
+ [[tab_ webController] webStateImpl]->UpdateHttpResponseHeaders(redirectUrl);
[[tab_ webController] webStateImpl]->OnNavigationCommitted(redirectUrl);
- [tab_ webDidStartLoadingURL:redirectUrl shouldUpdateHistory:YES];
base::string16 new_title = base::SysNSStringToUTF16(title);
[tab_ navigationManager]->GetLastCommittedItem()->SetTitle(new_title);
@@ -261,7 +261,6 @@ class TabTest : public BlockCleanupTest {
[[tab_ webController] loadWithParams:params];
[[[(id)mock_web_controller_ expect]
andReturnValue:OCMOCK_VALUE(kPageLoading)] loadPhase];
- [tab_ webDidStartLoadingURL:url shouldUpdateHistory:YES];
[[[(id)mock_web_controller_ expect]
andReturnValue:OCMOCK_VALUE(kPageLoaded)] loadPhase];
web_state_impl_->OnPageLoaded(url, true);
« no previous file with comments | « ios/chrome/browser/tabs/tab.mm ('k') | ios/web/navigation/crw_session_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698