Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Unified Diff: ios/web/public/web_state/ui/crw_web_delegate.h

Issue 2724383003: Removed -[CRWWebDelegate webDidStartLoadingURL:updateHistory:]. (Closed)
Patch Set: Fixed ios_web_unittests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/navigation/crw_session_controller.mm ('k') | ios/web/web_state/navigation_callbacks_inttest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/public/web_state/ui/crw_web_delegate.h
diff --git a/ios/web/public/web_state/ui/crw_web_delegate.h b/ios/web/public/web_state/ui/crw_web_delegate.h
index 638924497619f9425cfaaa86f33e43579fd04ca4..3fa7d1cbe519c967f6446d10470746f8ce600638 100644
--- a/ios/web/public/web_state/ui/crw_web_delegate.h
+++ b/ios/web/public/web_state/ui/crw_web_delegate.h
@@ -41,15 +41,8 @@ class GURL;
// Phase will be LOAD_REQUESTED.
- (void)webWillAddPendingURL:(const GURL&)url
transition:(ui::PageTransition)transition;
-// Called when webWillStartLoadingURL was called, but something went wrong, and
-// webDidStartLoadingURL will now never be called.
+// Called when webWillStartLoadingURL was called, but something went wrong.
- (void)webCancelStartLoadingRequest;
-// Called when the page URL has changed. Phase will be PAGE_LOADING. Can be
-// followed by webDidFinishWithURL or webWillStartLoadingURL.
-// |updateHistory| is YES if the URL should be added to the history DB.
-// TODO(crbug.com/692331): Remove this method and use |DidFinishNavigation|.
-- (void)webDidStartLoadingURL:(const GURL&)url
- shouldUpdateHistory:(BOOL)updateHistory;
// Called when the page load was cancelled by page activity (before a success /
// failure state is known). Phase will be PAGE_LOADED.
- (void)webLoadCancelled:(const GURL&)url;
« no previous file with comments | « ios/web/navigation/crw_session_controller.mm ('k') | ios/web/web_state/navigation_callbacks_inttest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698