Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2724363002: Migrate WTF::LinkedHashSet/ListHashSet::add() to ::insert() (Closed)

Created:
3 years, 9 months ago by pilgrim_google
Modified:
3 years, 9 months ago
CC:
Mads Ager (chromium), ajuma+watch-canvas_chromium.org, ajuma+watch_chromium.org, darktears, apavlov+blink_chromium.org, atotic+reviews_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-wtf_chromium.org, Rik, caseq+blink_chromium.org, cbiesinger, chromium-reviews, cmumford, danakj+watch_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, dgrogan+ng_chromium.org, dominicc+watchlist_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, Eric Willigers, fmalita+watch_chromium.org, fs, gavinp+loader_chromium.org, glebl+reviews_chromium.org, gyuyoung2, Nate Chapin, jbroman, jchaffraix+rendering, jfernandez, jsbell+idb_chromium.org, Justin Novosad, kenneth.christiansen, kinuko+watch, kouhei+svg_chromium.org, kouhei+heap_chromium.org, kozyatinskiy+blink_chromium.org, leviw+renderwatch, loading-reviews+fetch_chromium.org, loading-reviews_chromium.org, lushnikov+blink_chromium.org, Mikhail, oilpan-reviews, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+svgwatchlist_chromium.org, pfeldman+blink_chromium.org, Manuel Rego, rjwright, rwlbuis, Stephen Chennney, shans, sof, svillar, szager+layoutwatch_chromium.org, tyoshino+watch_chromium.org, webcomponents-bugzilla_chromium.org, Yoav Weiss, zoltan1, jsbell
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WTF::LinkedHashSet/ListHashSet::add() to ::insert() As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 Review-Url: https://codereview.chromium.org/2724363002 Cr-Commit-Position: refs/heads/master@{#454286} Committed: https://chromium.googlesource.com/chromium/src/+/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -143 lines) Patch
M third_party/WebKit/Source/core/css/FontFaceCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/FontFaceSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryMatcher.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentOrderedList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ResizeObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptedAnimationController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/V0CustomElementUpgradeCandidateMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/DOMWindowEventQueue.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasFontCache.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/FormController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/FloatingObjects.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/HitTestResult.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceBase.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/HitRegion.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontDataCache.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapCompactTest.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/LinkedHashSet.h View 3 chunks +4 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/wtf/ListHashSet.h View 4 chunks +6 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/wtf/ListHashSetTest.cpp View 21 chunks +44 lines, -44 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
pilgrim_google
3 years, 9 months ago (2017-03-02 15:15:29 UTC) #2
haraken
LGTM
3 years, 9 months ago (2017-03-02 15:47:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724363002/1
3 years, 9 months ago (2017-03-02 16:24:16 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 17:00:57 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0d6974fcc661b4ff8ae9e4b04eb2...

Powered by Google App Engine
This is Rietveld 408576698