Migrate WTF::LinkedHashSet/ListHashSet::add() to ::insert()

third_party/WebKit/Source/wtf/ListHashSet.h

 /*
  * Copyright (C) 2005, 2006, 2007, 2008, 2011, 2012 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2011, Benjamin Poulain <ikipou@gmail.com>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 167 matching lines @@
   // An alternate version of find() that finds the object by hashing and
   // comparing with some other type, to avoid the cost of type conversion.
   // The HashTranslator interface is defined in HashSet.
   template <typename HashTranslator, typename T>
   iterator find(const T&);
   template <typename HashTranslator, typename T>
   const_iterator find(const T&) const;
   template <typename HashTranslator, typename T>
   bool contains(const T&) const;
 
-  // The return value of add is a pair of a pointer to the stored value, and a
-  // bool that is true if an new entry was added.
-  template <typename IncomingValueType>
-  AddResult add(IncomingValueType&&);
+  // The return value of insert is a pair of a pointer to the stored value, and
+  // a bool that is true if an new entry was added.
   template <typename IncomingValueType>
   AddResult insert(IncomingValueType&&);
 
-  // Same as add() except that the return value is an iterator. Useful in
+  // Same as insert() except that the return value is an iterator. Useful in
   // cases where it's needed to have the same return value as find() and where
   // it's not possible to use a pointer to the storedValue.
   template <typename IncomingValueType>
   iterator addReturnIterator(IncomingValueType&&);
 
   // Add the value to the end of the collection. If the value was already in
   // the list, it is moved to the end.
   template <typename IncomingValueType>
   AddResult appendOrMoveToLast(IncomingValueType&&);
 
@@ skipping 557 matching lines @@
       "Cannot put raw pointers to garbage-collected classes into "
       "an off-heap ListHashSet. Use HeapListHashSet<Member<T>> instead.");
 }
 
 template <typename T, size_t inlineCapacity, typename U, typename V>
 inline ListHashSet<T, inlineCapacity, U, V>::ListHashSet(
     const ListHashSet& other)
     : m_head(nullptr), m_tail(nullptr) {
   const_iterator end = other.end();
   for (const_iterator it = other.begin(); it != end; ++it)
-    add(*it);
+    insert(*it);
 }
 
 template <typename T, size_t inlineCapacity, typename U, typename V>
 inline ListHashSet<T, inlineCapacity, U, V>::ListHashSet(ListHashSet&& other)
     : m_head(nullptr), m_tail(nullptr) {
   swap(other);
 }
 
 template <typename T, size_t inlineCapacity, typename U, typename V>
 inline ListHashSet<T, inlineCapacity, U, V>&
@@ skipping 127 matching lines @@
 
 template <typename T, size_t inlineCapacity, typename U, typename V>
 inline bool ListHashSet<T, inlineCapacity, U, V>::contains(
     ValuePeekInType value) const {
   return m_impl.template contains<BaseTranslator>(value);
 }
 
 template <typename T, size_t inlineCapacity, typename U, typename V>
 template <typename IncomingValueType>
 typename ListHashSet<T, inlineCapacity, U, V>::AddResult
-ListHashSet<T, inlineCapacity, U, V>::add(IncomingValueType&& value) {
+ListHashSet<T, inlineCapacity, U, V>::insert(IncomingValueType&& value) {
   createAllocatorIfNeeded();
   // The second argument is a const ref. This is useful for the HashTable
   // because it lets it take lvalues by reference, but for our purposes it's
   // inconvenient, since it constrains us to be const, whereas the allocator
   // actually changes when it does allocations.
   auto result = m_impl.template add<BaseTranslator>(
       std::forward<IncomingValueType>(value), *this->getAllocator());
   if (result.isNewEntry)
     appendNode(*result.storedValue);
   return AddResult(*result.storedValue, result.isNewEntry);
 }
 
 template <typename T, size_t inlineCapacity, typename U, typename V>
 template <typename IncomingValueType>
-typename ListHashSet<T, inlineCapacity, U, V>::AddResult
-ListHashSet<T, inlineCapacity, U, V>::insert(IncomingValueType&& value) {
-  return add(value);
-}
-
-template <typename T, size_t inlineCapacity, typename U, typename V>
-template <typename IncomingValueType>
 typename ListHashSet<T, inlineCapacity, U, V>::iterator
 ListHashSet<T, inlineCapacity, U, V>::addReturnIterator(
     IncomingValueType&& value) {
-  return makeIterator(add(std::forward<IncomingValueType>(value)).m_node);
+  return makeIterator(insert(std::forward<IncomingValueType>(value)).m_node);
 }
 
 template <typename T, size_t inlineCapacity, typename U, typename V>
 template <typename IncomingValueType>
 typename ListHashSet<T, inlineCapacity, U, V>::AddResult
 ListHashSet<T, inlineCapacity, U, V>::appendOrMoveToLast(
     IncomingValueType&& value) {
   createAllocatorIfNeeded();
   auto result = m_impl.template add<BaseTranslator>(
       std::forward<IncomingValueType>(value), *this->getAllocator());
@@ skipping 178 matching lines @@
   // through the HashTable. That includes m_head and m_tail so we do not have
   // to explicitly trace them here.
   m_impl.trace(visitor);
 }
 
 }  // namespace WTF
 
 using WTF::ListHashSet;
 
 #endif  // WTF_ListHashSet_h