Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc

Issue 2724363002: Migrate WTF::LinkedHashSet/ListHashSet::add() to ::insert() (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc
index 297186f446c6755b07183c90889d9e1d9059114c..d180ea9dc1c8fabe4d9c5b14cd1992093077f3cf 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc
@@ -67,7 +67,7 @@ NGFragmentBuilder& NGFragmentBuilder::AddChild(
size_t oof_index = 0;
for (auto& oof_node : child->OutOfFlowDescendants()) {
NGStaticPosition oof_position = oof_positions[oof_index++];
- out_of_flow_descendant_candidates_.add(oof_node);
+ out_of_flow_descendant_candidates_.insert(oof_node);
out_of_flow_candidate_placements_.push_back(
OutOfFlowPlacement{child_offset, oof_position});
}
@@ -108,7 +108,7 @@ NGFragmentBuilder& NGFragmentBuilder::SetBfcOffset(
NGFragmentBuilder& NGFragmentBuilder::AddOutOfFlowChildCandidate(
NGBlockNode* child,
NGLogicalOffset child_offset) {
- out_of_flow_descendant_candidates_.add(child);
+ out_of_flow_descendant_candidates_.insert(child);
NGStaticPosition child_position =
NGStaticPosition::Create(writing_mode_, direction_, NGPhysicalOffset());
out_of_flow_candidate_placements_.push_back(
@@ -146,7 +146,7 @@ void NGFragmentBuilder::GetAndClearOutOfFlowDescendantCandidates(
builder_relative_position.type = oof_placement.descendant_position.type;
builder_relative_position.offset =
child_offset + oof_placement.descendant_position.offset;
- descendants->add(oof_node);
+ descendants->insert(oof_node);
descendant_positions->push_back(builder_relative_position);
}
out_of_flow_descendant_candidates_.clear();
@@ -156,7 +156,7 @@ void NGFragmentBuilder::GetAndClearOutOfFlowDescendantCandidates(
NGFragmentBuilder& NGFragmentBuilder::AddOutOfFlowDescendant(
NGBlockNode* descendant,
const NGStaticPosition& position) {
- out_of_flow_descendants_.add(descendant);
+ out_of_flow_descendants_.insert(descendant);
out_of_flow_positions_.push_back(position);
return *this;
}

Powered by Google App Engine
This is Rietveld 408576698