Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2724313002: Split transitions update storage between custom and standard properties (Closed)

Created:
3 years, 9 months ago by alancutter (OOO until 2018)
Modified:
3 years, 9 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split transitions update storage between custom and standard properties This patch creates a distinction between transition interpolations for custom vs standard CSS properties. This is required to support CSS Transitions on registered custom properties as they need to be calculated and applied in separate phases. This patch is a refactor and does not change behaviour. BUG=671904 Review-Url: https://codereview.chromium.org/2724313002 Cr-Commit-Position: refs/heads/master@{#454821} Committed: https://chromium.googlesource.com/chromium/src/+/095ff780d828ee632f83ed54cfa9caf67179d7f0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -14 lines) Patch
M third_party/WebKit/Source/core/animation/css/CSSAnimationUpdate.h View 5 chunks +23 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (9 generated)
alancutter (OOO until 2018)
3 years, 9 months ago (2017-03-03 08:35:08 UTC) #3
Eric Willigers
lgtm
3 years, 9 months ago (2017-03-04 04:21:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724313002/1
3 years, 9 months ago (2017-03-05 23:15:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/378476)
3 years, 9 months ago (2017-03-05 23:20:49 UTC) #9
alancutter (OOO until 2018)
+meade for changes to StyleResolver.
3 years, 9 months ago (2017-03-05 23:58:00 UTC) #11
meade_UTC10
lgtm
3 years, 9 months ago (2017-03-06 03:15:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724313002/1
3 years, 9 months ago (2017-03-06 03:55:08 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 03:59:10 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/095ff780d828ee632f83ed54cfa9...

Powered by Google App Engine
This is Rietveld 408576698